Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

[15:31:39 CST(-0600)] <jwennmacher> OK

[15:35:22 CST(-0600)] <EricDalquist> ok ... so my thoughts I think line up with yours

[15:35:35 CST(-0600)] <EricDalquist> change createAggregationsQueryKey to return a Set<K>

[15:35:53 CST(-0600)] <EricDalquist> and change BaseAggregationDao

[15:35:54 CST(-0600)] <EricDalquist> getAggregations(DateTime start, DateTime end, K key, AggregatedGroupMapping... aggregatedGroupMappings)

[15:35:57 CST(-0600)] <EricDalquist> to

[15:36:02 CST(-0600)] <EricDalquist> getAggregations(DateTime start, DateTime end, Set<K> key, AggregatedGroupMapping... aggregatedGroupMappings)

[15:36:03 CST(-0600)] <jwennmacher> Adjustment to my suggested solution. Have BaseStatsticsReportController method createAggregationsQueryKey return a Set<K>, and pass that Set<K> into a JpaBaseAggregationDao method that accepts a set<K> instead

[15:36:09 CST(-0600)] <jwennmacher> Yep!!!

[15:36:16 CST(-0600)] <EricDalquist> perhaps add that as an overloaded of the existing getAggregations