Page Comparison

[02:08:51 CDT(-0500)] * Topic is 'http://uportal.pastebin.com/ - https://wiki.jasig.org/display/UPC/uportal+IRC+Logs' set by EricDalquist!~apollo@76.210.64.142 on 17:44:12 CDT(-0500)
[08:58:49 CDT(-0500)] <Arvids> hey, Eric
[08:59:08 CDT(-0500)] <EricDalquist> hey there
[08:59:12 CDT(-0500)] <EricDalquist> nice fix for the portlet title
[09:00:20 CDT(-0500)] <Arvids> yeah, i also played with LocaleResolvers and Interceptors in order to improve locale determination
[09:00:32 CDT(-0500)] <EricDalquist> oh awesome
[09:01:12 CDT(-0500)] <Arvids> i hope changing response locale doesn't break anything
[09:01:21 CDT(-0500)] <EricDalquist> It shouldn't
[09:01:24 CDT(-0500)] <Arvids> in fact i wonder why that has not been done before
[09:01:46 CDT(-0500)] <EricDalquist> all of us us-en people never thought to do it
[09:01:56 CDT(-0500)] <Arvids>
[09:02:02 CDT(-0500)] <EricDalquist> its really handy having someone that is not using en-us
[09:02:06 CDT(-0500)] <EricDalquist> to find all the stuff we don't think about
[09:02:27 CDT(-0500)] <Arvids> yeah, but that jvm-locale really confused me
[09:02:37 CDT(-0500)] <Arvids> spent whole day debugging it
[09:03:09 CDT(-0500)] <Arvids> and one more thing i wanted to ask... could it be possible to switch to resource-bundle based portlet titles?
[09:04:02 CDT(-0500)] <Arvids> because if portlet title, description and keywords are in portlet.xml, then there's no possibility to enable i18n
[09:04:42 CDT(-0500)] <EricDalquist> hrm, sure I think the portlet spec supports portlets using resource bundles for portlet titles
[09:04:46 CDT(-0500)] <Arvids> but that requires separate .properties file for each portlet
[09:04:55 CDT(-0500)] <EricDalquist> right
[09:05:19 CDT(-0500)] <EricDalquist> really what we need to do, and this would be for 4.1, is add locale support in the portlet-definition XML data file
[09:05:49 CDT(-0500)] <Arvids> indeed
[09:06:12 CDT(-0500)] <EricDalquist> now that we're moving to XSDs for the data files it should be easy to codify
[09:06:23 CDT(-0500)] <Arvids> but that would work only for dynamic titles
[09:06:43 CDT(-0500)] <EricDalquist> it would work for static titles (those set by the portal)
[09:06:51 CDT(-0500)] <EricDalquist> for portlets that have dynamic titles enabled
[09:06:56 CDT(-0500)] <EricDalquist> we would need the resource bundle
[09:06:57 CDT(-0500)] <Arvids> ahhh... yes
[09:07:07 CDT(-0500)] <EricDalquist> but very few jasig portlets use dynamic titles
[09:07:08 CDT(-0500)] <Arvids> mixed them
[09:07:14 CDT(-0500)] <EricDalquist> since they are more utility portlets
[09:07:21 CDT(-0500)] <EricDalquist> and published under random names
[09:07:56 CDT(-0500)] <Arvids> at least now i feel more like portal is 4.0-ready after closing those tickets
[09:08:06 CDT(-0500)] <EricDalquist> great
[09:08:14 CDT(-0500)] <EricDalquist> yeah I'm running through issues as quick as I can
[09:08:20 CDT(-0500)] <EricDalquist> have to go report more spring bugs
[09:46:22 CDT(-0500)] <athena> doesn't the portlet.xml format support i18n titles?
[09:48:02 CDT(-0500)] <athena> or i guess that's the mention of resource-bundle
[09:49:06 CDT(-0500)] <EricDalquist> yes
[15:10:26 CDT(-0500)] <EricDalquist> oh athena did you see that the rendering pipeline comments bug is fixed?
[15:10:35 CDT(-0500)] <EricDalquist> It was all Spring's fault
[15:21:26 CDT(-0500)] <athena> i did!
[15:21:32 CDT(-0500)] <athena> awesome that that's fixed
[15:21:39 CDT(-0500)] <athena> i'll ask jeff if i need to integrate patches
[15:21:45 CDT(-0500)] <EricDalquist> I was using some code they have to go from SAX to StAX
[15:21:58 CDT(-0500)] <EricDalquist> and their SAX ContentHandler doesn't imlement LexicalHandler
[15:22:11 CDT(-0500)] <EricDalquist> so DTDs, Comments, XML Entities and CDATA all got stripped
[15:22:28 CDT(-0500)] <EricDalquist> so it all fixed the DTD config issue
[15:22:36 CDT(-0500)] <EricDalquist> now setting the DTD in the XSL works
[15:52:05 CDT(-0500)] <EricDalquist> athena I'm trying to reproduce https://issues.jasig.org/browse/UP-3120
[15:52:09 CDT(-0500)] <EricDalquist> I logged in as admin
[15:52:16 CDT(-0500)] <EricDalquist> go the url for the portlet manager
[15:52:21 CDT(-0500)] <EricDalquist> then logged in as student
[15:52:22 CDT(-0500)] <EricDalquist> no luck
[15:52:34 CDT(-0500)] <athena> hm, really?
[15:52:44 CDT(-0500)] <athena> what happens?
[15:52:56 CDT(-0500)] <EricDalquist> I just go back to my home tab
[15:53:07 CDT(-0500)] <EricDalquist> can you show me a URL that exhibts this?
[15:53:25 CDT(-0500)] <athena> http://localhost:8080/uPortal/p/portlet-admin
[15:53:34 CDT(-0500)] <athena> logged in as student right now
[15:53:43 CDT(-0500)] <EricDalquist> oh ... wtf
[15:53:44 CDT(-0500)] <EricDalquist> lol
[15:53:45 CDT(-0500)] <EricDalquist> yeah
[15:53:46 CDT(-0500)] <EricDalquist> I see that
[15:53:47 CDT(-0500)] <athena> lol
[15:53:56 CDT(-0500)] <EricDalquist> not sure why my other url didn't work
[15:53:59 CDT(-0500)] <athena> yeah i figure that's one we really havfe to fix before the release
[15:54:00 CDT(-0500)] <athena> dunno!
[15:54:06 CDT(-0500)] <EricDalquist> yeah
[15:54:08 CDT(-0500)] <EricDalquist> looking at it now
[15:54:09 CDT(-0500)] <athena> must just be a missing permission check i'm guessing/
[15:54:55 CDT(-0500)] <EricDalquist> yup
[15:55:00 CDT(-0500)] <EricDalquist> in a couple places though
[16:03:44 CDT(-0500)] <athena> hmmm.
[16:03:50 CDT(-0500)] <athena> something bad seems to have happened to the mobile profile
[16:04:09 CDT(-0500)] <athena> setting a breakpoint shows that the mobile user agent is still matching correctly and returning the mobile profile name
[16:04:14 CDT(-0500)] <athena> but seeing the regular theme
[16:05:13 CDT(-0500)] <EricDalquist> hrm
[16:05:31 CDT(-0500)] <EricDalquist> so the profile object is for mobile?
[16:05:53 CDT(-0500)] <athena> yeah
[16:07:40 CDT(-0500)] <EricDalquist> you know when it last worked?
[16:07:49 CDT(-0500)] <EricDalquist> I'm trying to think if my changes last night could have broken in
[16:07:50 CDT(-0500)] <EricDalquist> it
[16:08:25 CDT(-0500)] <athena> no, wasn't last night
[16:08:32 CDT(-0500)] <athena> noticed it for the first time yesterday, i think
[16:08:36 CDT(-0500)] <athena> but i hadn't checked it in a while
[16:08:47 CDT(-0500)] <EricDalquist> hrm
[16:11:28 CDT(-0500)] <athena> hm, layout id for that profile is 0
[16:11:31 CDT(-0500)] <athena> which is probably a bad sign
[16:11:52 CDT(-0500)] * athena sighs
[16:12:03 CDT(-0500)] <athena> just like you, i hate this part of the codebase
[16:12:16 CDT(-0500)] <EricDalquist> uhg
[16:12:18 CDT(-0500)] <EricDalquist> yes
[16:12:22 CDT(-0500)] <EricDalquist> I can't wait for us to have time
[16:12:24 CDT(-0500)] <EricDalquist> to sit down
[16:12:35 CDT(-0500)] <EricDalquist> and do a complete redesign of the user - profile - layout model
[16:12:38 CDT(-0500)] <EricDalquist> it is SO BROKEN
[16:13:00 CDT(-0500)] <athena> yeah :/
[16:13:06 CDT(-0500)] <athena> errr where is the theme stuff in the db anyway?
[16:13:09 CDT(-0500)] <athena> stares
[16:13:33 CDT(-0500)] <athena> oh nm
[16:13:36 CDT(-0500)] <athena> forgot we combined it
[16:13:56 CDT(-0500)] <athena> ok
[16:14:01 CDT(-0500)] <athena> yeah, the theme id is actually wrong
[16:14:07 CDT(-0500)] <athena> so maybe this is just an import/export issue
[16:14:11 CDT(-0500)] <athena> which would be kind of a relief
[16:16:43 CDT(-0500)] <EricDalquist> ah
[16:16:45 CDT(-0500)] <EricDalquist> ok
[16:21:51 CDT(-0500)] <athena> heh, ok
[16:21:55 CDT(-0500)] <athena> do we have user_profile_theme_force set to true?
[16:22:06 CDT(-0500)] <athena> guessing that that's the problem
[16:22:14 CDT(-0500)] <EricDalquist> oh yeah
[16:22:16 CDT(-0500)] <EricDalquist> oops
[16:22:22 CDT(-0500)] <EricDalquist> I accidentally stuck that in
[16:22:27 CDT(-0500)] <EricDalquist> that's in the bottom of portal.properties
[16:22:28 CDT(-0500)] <EricDalquist> I'll fix it
[16:22:29 CDT(-0500)] <athena> oh ok
[16:22:39 CDT(-0500)] <athena> well at least that turned out not to be painful!
[16:22:42 CDT(-0500)] <athena> i was worried for a minute there
[16:34:26 CDT(-0500)] <EricDalquist> I also can't wait for spring security permissions
[16:34:37 CDT(-0500)] <EricDalquist> so I can just codify portlet permissions in the portlet definition registry
[16:34:44 CDT(-0500)] <EricDalquist> and remove all the other checks
[16:38:15 CDT(-0500)] <athena> yes!
[16:38:16 CDT(-0500)] <athena> yes yes yes
[16:38:19 CDT(-0500)] <athena> going to be so aweosme
[16:38:23 CDT(-0500)] * athena cheers
[16:38:27 CDT(-0500)] <athena> 4.1?
[16:38:29 CDT(-0500)] <EricDalquist> yes
[16:38:49 CDT(-0500)] <EricDalquist> if we could get a faster release cycle we could do perms for 4.1
[16:38:54 CDT(-0500)] <EricDalquist> and layout/profile for 4.2
[16:39:04 CDT(-0500)] <EricDalquist> the more we refactor the easier parralle dev will be
[16:39:12 CDT(-0500)] <EricDalquist> since stuff won't be so insanely coupled
[16:39:17 CDT(-0500)] <athena> yeah
[16:39:28 CDT(-0500)] <athena> though i think layout/profile will wind up being pretty high-priority to umobile
[16:39:34 CDT(-0500)] <athena> be interesting to see how that pans out
[16:39:38 CDT(-0500)] <EricDalquist> yes
[16:39:40 CDT(-0500)] <EricDalquist> that's true
[16:39:44 CDT(-0500)] <athena> whether that becomes a factor and can help contribute
[16:39:47 CDT(-0500)] <EricDalquist> being able to actually have multiple layouts
[16:39:52 CDT(-0500)] <athena> though honestly it'll make our lives easier, ugh
[16:41:25 CDT(-0500)] <EricDalquist> you have a pointer to code that does the "can render portlet" authz check?
[16:42:35 CDT(-0500)] <athena> let me find it
[16:42:45 CDT(-0500)] * EricDalquist really hates the current permissions API
[16:42:50 CDT(-0500)] <athena> me too
[16:42:54 CDT(-0500)] <EricDalquist> and the fact that we scatter it everywhere
[16:42:57 CDT(-0500)] <athena> should be using AuthorizationImpl.canPrincipalRender
[16:43:39 CDT(-0500)] <athena> actuall . . maybe not directly
[16:43:45 CDT(-0500)] <EricDalquist> yay static class initializers
[16:43:46 CDT(-0500)] <athena> here we go
[16:43:52 CDT(-0500)] <athena> take a look at ChannelListController
[16:43:59 CDT(-0500)] <EricDalquist> ah right
[16:44:01 CDT(-0500)] <athena> IAuthorizationPrincipal ap = AuthorizationService.instance().newPrincipal(ei.getKey(), ei.getType());
[16:44:07 CDT(-0500)] <athena> then you'd do ap.canRender
[16:44:19 CDT(-0500)] <athena> this is doing canSubscribe, but really it's the same thing
[16:44:35 CDT(-0500)] <EricDalquist> got it