Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

[00:24:03 EDT(-0400)] * esm_ (n=esm@207-53-193-113.dynamic-dsl.qis.net) has joined ##uportal
[02:41:56 EDT(-0400)] * EiNZTEiN (n=einztein@di197.opencominc.com) has joined ##uportal
[08:37:24 EDT(-0400)] * esm (n=esm@207-53-193-113.dynamic-dsl.qis.net) has joined ##uportal
[09:18:58 EDT(-0400)] * colinclark (n=colin@bas1-toronto09-1279336150.dsl.bell.ca) has joined ##uportal
[09:30:21 EDT(-0400)] * esm (n=esm@128.220.212.115) has joined ##uportal
[09:36:55 EDT(-0400)] * anastasiac (n=team@142.150.154.149) has joined ##uportal
[09:43:49 EDT(-0400)] * EricDalquist (n=EricDalq@adsl-76-204-102-88.dsl.mdsnwi.sbcglobal.net) has joined ##uportal
[09:53:32 EDT(-0400)] * theclown (n=theclown@142.150.154.101) has joined ##uportal
[10:06:25 EDT(-0400)] * colinclark (n=colin@bas1-toronto09-1279336150.dsl.bell.ca) has joined ##uportal
[10:08:05 EDT(-0400)] * esm (n=esm@128.220.212.115) has joined ##uportal
[10:27:52 EDT(-0400)] <Tuomaz> Good morning
[10:29:00 EDT(-0400)] * EiNZTEiN (n=einztein@205.241.143.4) has joined ##uportal
[10:30:05 EDT(-0400)] <Tuomaz> We have modified CPortletAdapter to provide a CAS-ticket (proxyTicket) to our portlets. This works fine in 2.5.3. I have fixed the code for 2.6.0 and it works fine there too.
[10:32:18 EDT(-0400)] <Tuomaz> Now I'm having problems with this in 2.6.1. Has there been any changes in CasFilteredSecurityContext or something close to that?
[10:33:42 EDT(-0400)] <EricDalquist> I'm not sure: http://www.ja-sig.org/issues/browse/UP?report=com.atlassian.jira.plugin.system.project:changelog-panel
[10:34:01 EDT(-0400)] <EricDalquist> that is the changelog pannel for uPortal. 2.6.1 should be at the bottom of the page to see a summary of what was done for the release
[10:35:55 EDT(-0400)] <Tuomaz> thanx
[10:36:17 EDT(-0400)] <EricDalquist> yup
[10:36:43 EDT(-0400)] * colinclark (n=colin@142.150.154.101) has joined ##uportal
[10:41:32 EDT(-0400)] * EiNZTEiN (n=einztein@205.241.143.4) has joined ##uportal
[10:45:31 EDT(-0400)] * michelled (n=team@142.150.154.199) has joined ##uportal
[12:49:59 EDT(-0400)] * EiNZTEiN (n=einztein@205.241.143.4) has joined ##uportal
[12:53:19 EDT(-0400)] * EiNZTEiN (n=einztein@205.241.143.4) has joined ##uportal
[13:31:59 EDT(-0400)] * deuce (n=deuce@ip68-3-31-85.ph.ph.cox.net) has joined ##uportal
[13:32:37 EDT(-0400)] <deuce> eric?
[13:32:42 EDT(-0400)] <EricDalquist> hey
[13:32:52 EDT(-0400)] <deuce> I'm getting another pluto error
[13:33:05 EDT(-0400)] <EricDalquist> (smile)
[13:33:14 EDT(-0400)] <deuce> in rendering a portlet as guest,
[13:33:15 EDT(-0400)] <EricDalquist> bring it on
[13:33:17 EDT(-0400)] <deuce> hehe
[13:33:30 EDT(-0400)] <deuce> a.lang.NullPointerException
[13:33:30 EDT(-0400)] <deuce> at org.apache.pluto.internal.impl.PortletRequestImpl.createUserInfoMap(PortletRequestImpl.java:461)
[13:33:31 EDT(-0400)] <deuce> at org.apache.pluto.internal.impl.PortletRequestImpl.getAttribute(PortletRequestImpl.java:399)
[13:33:31 EDT(-0400)] <deuce> at org.springframework.web.portlet.FrameworkPortlet.getUsernameForRequest(FrameworkPortle
[13:33:53 EDT(-0400)] <deuce> looks like this statement is returning null
[13:33:53 EDT(-0400)] <deuce> Map allMap = container.getOptionalContainerServices()
[13:33:53 EDT(-0400)] <deuce> //PLUTO-388 fix:
[13:33:54 EDT(-0400)] <deuce> //The PortletWindow is currently ignored in the implementing class
[13:33:54 EDT(-0400)] <deuce> // See: org.apache.pluto.core.DefaultUserInfoService
[13:33:54 EDT(-0400)] <deuce> .getUserInfoService().getUserInfo( this, this.internalPortletWindow );
[13:34:31 EDT(-0400)] <deuce> love the embedded comments...
[13:34:34 EDT(-0400)] <EricDalquist> hrm
[13:34:35 EDT(-0400)] <EricDalquist> yeah
[13:34:40 EDT(-0400)] <EricDalquist> and the long dotted line
[13:34:49 EDT(-0400)] <EricDalquist> what version of uportal was this?
[13:34:57 EDT(-0400)] <deuce> up3 trunk
[13:35:28 EDT(-0400)] <EricDalquist> ah and this is with a guest user ...
[13:35:32 EDT(-0400)] <deuce> yup
[13:35:44 EDT(-0400)] <EricDalquist> let me go look at some code
[13:36:12 EDT(-0400)] <deuce> note the pluto line number will be a little off .. i'm using pluto-1.1.6-snap+
[13:36:33 EDT(-0400)] <deuce> but i get the same error with the version bundled in up3
[13:36:58 EDT(-0400)] <EricDalquist> yeah I'm thinking either the portal is returning a null for a guest user when it should be an empty Map
[13:37:07 EDT(-0400)] <EricDalquist> or Pluto isn't handling a null it is supposed to
[13:37:16 EDT(-0400)] <EricDalquist> I just need to figure out what the 'correct' behavior here is
[13:39:43 EDT(-0400)] <EricDalquist> so you're getting a null allMap there and then a later line is failing with the NPE?
[13:39:50 EDT(-0400)] <deuce> correct
[13:41:55 EDT(-0400)] <EricDalquist> looks like a pluto bug
[13:42:12 EDT(-0400)] <EricDalquist> according to the spec null should be returned for USER_INFO for un-authenticated users
[13:42:32 EDT(-0400)] <EricDalquist> but the createUserInfoMap method has no handling for dealing with a null Map from the portal
[13:44:12 EDT(-0400)] <deuce> to workout, i can just bypass the attributes copying section?
[13:45:23 EDT(-0400)] <EricDalquist> just skip getting the attribute in your portlet you mean?
[13:45:29 EDT(-0400)] <deuce> hmm.. then i have to account for no user.login.id in my portlet
[13:45:33 EDT(-0400)] <deuce> in pluto
[13:45:56 EDT(-0400)] <EricDalquist> ah, well you should be using request.getRemoteUser to get the login name
[13:46:16 EDT(-0400)] <EricDalquist> in pluto if you want to fix it, right after it gets allMap just do
[13:46:23 EDT(-0400)]

Wiki Markup
&lt;EricDalquist&gt; if (allMap == null) { return null; }

[13:46:37 EDT(-0400)] <deuce> okie dokie
[13:46:55 EDT(-0400)] <EricDalquist> spring's getUsernameForRequest tries a bunch of stuff but getRemoteUser should be all that is needed
[13:55:40 EDT(-0400)] <deuce> getRemoteUser returns null
[13:56:33 EDT(-0400)] <EricDalquist> for the guest user?
[13:56:36 EDT(-0400)] <EricDalquist> that is correct
[13:56:37 EDT(-0400)] <deuce> si
[13:56:51 EDT(-0400)] <EricDalquist> for un-authd users you get null for any user info related data
[13:57:42 EDT(-0400)] <deuce> hmm.. ok. i can work around that
[13:57:46 EDT(-0400)] <deuce> thx
[13:57:55 EDT(-0400)] <EricDalquist> yup
[13:58:04 EDT(-0400)] <EricDalquist> I'll go file a bug for that pluto issue
[16:09:35 EDT(-0400)] <EiNZTEiN> EricDalquist, do we have any news on the whole guest login problem with 2.6 (that I mentioned a while back?)
[16:10:13 EDT(-0400)] <EricDalquist> which was that and is there a jira issue for it?
[16:23:34 EDT(-0400)] <EiNZTEiN> no jira issue yet until we figure out where things went wrong
[16:23:39 EDT(-0400)] <EiNZTEiN> if on my end or uportal's
[16:23:40 EDT(-0400)] <EiNZTEiN> (smile)
[16:24:20 EDT(-0400)] <EiNZTEiN> basically, logging with guest-lo and changing the default theme to a new one doesn't apply to logged out users
[16:24:21 EDT(-0400)] <EiNZTEiN> :S
[16:24:35 EDT(-0400)] <EricDalquist> ah yeah
[16:24:38 EDT(-0400)] <EricDalquist> and restarting didn't fix it
[16:25:10 EDT(-0400)] <EiNZTEiN> exactly
[16:25:43 EDT(-0400)] <EricDalquist> yeah I have no idea, you can create a Jira issue to document it especially if you can reproduce it in an out-of-the-box uPortal isntance
[16:26:06 EDT(-0400)] <EricDalquist> I personally am not working on anything 2.x related right now so I won't have time to look into it
[16:27:13 EDT(-0400)] <EricDalquist> I can't remember, could you reproduce it on a bare instance?
[17:15:40 EDT(-0400)] * michelled (n=team@142.150.154.199) has left ##uportal
[18:54:24 EDT(-0400)] * esm (n=esm@207-53-193-233.dynamic-dsl.qis.net) has joined ##uportal
[21:47:49 EDT(-0400)] * EiNZTEiN (n=einztein@205.241.143.4) has joined ##uportal
[21:58:00 EDT(-0400)] * apetro_LD830_ubu (n=apetro_L@ip68-98-37-188.ph.ph.cox.net) has joined ##uportal