Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

JavaDoc comments are not included for methods declared by the IEntityNameFinder interface. We are not re-specifying these methods, we're just implementing them, so appropriate comments in PersonDirNameFinder are comments about the implementation. By eliminating duplication of the method specifications in both IEntityNameFinder and in this class we eliminate the possibility of these comments getting out of sync.

Taking the advice present in the code to "put your documentation comment here", the private method primGetName() now has a JavaDoc comment.

primGetNames()

Dropped method primGetNames() because all this private method did was give us access to the private field private SoftHashMap names. The method was private and so was not providing an opportunity for anyone to extend this class and override the method to have us use some other SoftHashMapMap.

Thread safety

This implementation of getName wasn't threadsafe: JIRA issue for fix for uP 2.4.3 JIRA issue for fix for uP 2.5

...