Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

[16:42:56 CDT(-0500)] <EricDalquist> that lets you re-use this logic for other aggregations down the road

[16:43:10 CDT(-0500)] <EricDalquist> since the "fill in the blank" logic is going to be interval specific

[16:43:11 CDT(-0500)] <EricDalquist> hrm

[16:43:12 CDT(-0500)] <EricDalquist> actuall

[16:43:16 CDT(-0500)] <EricDalquist> damn terms/quarters

[16:43:28 CDT(-0500)] <EricDalquist> because of those

[16:43:40 CDT(-0500)] <EricDalquist> you should add "public <T extends BaseAggregation> List<T> fillInBlanks(List<T> data, T blank)" to AggregationIntervalHelper

[16:43:50 CDT(-0500)] <EricDalquist> and implement it in AggregationIntervalHelperImpl

[16:44:05 CDT(-0500)] <EricDalquist> since you'll need DB lookups to figure if there are missing terms/quarters