Page Comparison

[01:03:36 EDT(-0400)] * [jlee] (n=jlee@adsl-074-184-125-241.sip.asm.bellsouth.net) has joined ##uportal
[03:16:27 EDT(-0400)] * lennard1 (n=sparhk@ip68-98-56-21.ph.ph.cox.net) has joined ##uportal
[03:40:36 EDT(-0400)] * higmad (n=chatzill@pcit-8752.hig.se) has joined ##uportal
[09:18:50 EDT(-0400)] * athena (n=athena@99.129.100.66) has joined ##uportal
[09:22:53 EDT(-0400)] * fj4000 (n=Jacob@142.150.154.106) has joined ##uportal
[09:57:06 EDT(-0400)] * EricDalquist (n=dalquist@bohemia.doit.wisc.edu) has joined ##uportal
[10:00:21 EDT(-0400)] * jessm (n=Jess@c-71-232-1-65.hsd1.ma.comcast.net) has joined ##uportal
[10:11:09 EDT(-0400)] * colinclark (n=colin@bas2-toronto09-1176393934.dsl.bell.ca) has joined ##uportal
[10:11:24 EDT(-0400)] * lennard1 (n=sparhk@ip68-98-56-21.ph.ph.cox.net) has left ##uportal
[10:28:41 EDT(-0400)] * lennard1 (n=sparhk@wsip-98-174-242-39.ph.ph.cox.net) has joined ##uportal
[11:11:01 EDT(-0400)] <athena> EricDalquist: have you used the regular web proxy portlet CPD to successfully create a portlet lately?
[11:11:12 EDT(-0400)] <EricDalquist> no
[11:11:14 EDT(-0400)] <athena> i can get the simple version up and running without any issues
[11:11:17 EDT(-0400)] <athena> ah, ok
[11:11:18 EDT(-0400)] <EricDalquist> it was completely broken in 2.0
[11:11:20 EDT(-0400)] <EricDalquist> er 3.0
[11:11:21 EDT(-0400)] <EricDalquist> er
[11:11:24 EDT(-0400)] <athena> ah, ok
[11:11:27 EDT(-0400)] <EricDalquist> brain is not awake yet
[11:11:33 EDT(-0400)] <athena> ugh i hear that
[11:11:34 EDT(-0400)] <EricDalquist> it was completely broken in 3.1
[11:11:39 EDT(-0400)] <EricDalquist> but semi-fixed in 3.1.1
[11:11:51 EDT(-0400)] <athena> ah, ok
[11:11:55 EDT(-0400)] <athena> i think i'm looking at 3.1
[11:12:07 EDT(-0400)] <EricDalquist> the problem is the old channel managers handling of PORTLET. channel parameters
[11:12:18 EDT(-0400)] <athena> ah
[11:12:30 EDT(-0400)] <EricDalquist> which was removed in 3.1 when the entity files were updated to have a prefs block
[11:12:34 EDT(-0400)] <athena> maybe i should just try it in the trunk and see how it works there
[11:12:35 EDT(-0400)] <EricDalquist> the problem is that broke how CPDs
[11:12:36 EDT(-0400)] <EricDalquist> work
[11:12:42 EDT(-0400)] <athena> gotcha
[11:12:55 EDT(-0400)] <EricDalquist> so hopefully if the CPDs are updated to use the new prefs support you added
[11:13:01 EDT(-0400)] <EricDalquist> they should work nicely in trunk
[11:13:02 EDT(-0400)] * michelled (n=team@142.150.154.193) has joined ##uportal
[11:13:07 EDT(-0400)] <athena> so was the channel manager not updated to recognized PORTLET. parameters as preferences?
[11:16:08 EDT(-0400)] <athena> one thing that's probably still a little ambiguous in the new portlet is handling blank parameters
[11:16:32 EDT(-0400)] <EricDalquist> well when I added the prefs support I removed the PORTLET. parameter support
[11:16:34 EDT(-0400)] <athena> i'm not sure if empty strings should be persisted as such, and if the answer is different for parameters vs. preferences
[11:16:39 EDT(-0400)] <EricDalquist> thinking it was only used in .channel files
[11:16:39 EDT(-0400)] <athena> ah, ok
[11:16:52 EDT(-0400)] <EricDalquist> not realizing that CPDs also used it
[11:16:56 EDT(-0400)] <athena> i actually did add some legacy support for those parameters to the new portlet
[11:17:10 EDT(-0400)] <EricDalquist> ok
[11:17:24 EDT(-0400)] <athena> though i'm not sure multi-valued support will work for PORTLET. parameters
[11:17:30 EDT(-0400)] <athena> but at least some handling is there
[11:17:32 EDT(-0400)] <EricDalquist> it won't
[11:17:36 EDT(-0400)] <EricDalquist> yeah
[11:17:45 EDT(-0400)] <EricDalquist> at least handling the single-valued case that has been there in the past is good
[11:17:54 EDT(-0400)] <EricDalquist> that works mostly in 3.1.1 right now
[11:17:59 EDT(-0400)] <athena> cool
[11:18:13 EDT(-0400)] <EricDalquist> ChrisH reported an issue when going it edit a portlet with PORTLET. CPD params
[11:18:22 EDT(-0400)] <athena> ah
[11:18:23 EDT(-0400)] <EricDalquist> the problem is the values are not loaded back up correctly for editing
[11:18:31 EDT(-0400)] <athena> gotcha
[11:25:48 EDT(-0400)] * holdorph (n=holdorph@uni1.unicon.net) has joined ##uportal
[11:43:55 EDT(-0400)] <athena> ok EricDalquist - i'm running into a problem in trunk that seems to be caused by blank parameters
[11:44:01 EDT(-0400)] <athena> i'm guessing that either
[11:44:26 EDT(-0400)] <athena> we need to update the portlet admin portlet to not persist blank values for portlet preferences
[11:44:38 EDT(-0400)] <athena> or we need to update the web proxy portlet to ignore blank values
[11:44:58 EDT(-0400)] <athena> the first seems like it's likely more consistent with channel parameter handling
[11:45:05 EDT(-0400)] <EricDalquist> yeah
[11:45:08 EDT(-0400)] <athena> ok
[11:45:09 EDT(-0400)] <EricDalquist> I think the first would be better
[11:45:10 EDT(-0400)] <athena> i can do that then
[11:45:18 EDT(-0400)] <athena> i wasn't sure what the correct behavior was when i was writing that code
[11:46:01 EDT(-0400)] <athena> so the rules should probably be that we only persist a list of preferences if there's at least one non-blank value
[11:46:10 EDT(-0400)] <EricDalquist> yeah
[11:46:22 EDT(-0400)] <athena> if there's one non-blank value and one blank one, do we want to persist just the non-blank one?
[11:46:37 EDT(-0400)] <athena> are there cases where you'd expect to be able to add empty strings to the preferences list?
[11:47:07 EDT(-0400)] <EricDalquist> Even though to code null "" and "some data" are all different I think for the sake of UI sanity we only persist non empty strings
[11:47:14 EDT(-0400)] <EricDalquist> I'm sure someone might come up with one
[11:47:20 EDT(-0400)] <EricDalquist> but my guess is that is the rare exception
[11:47:44 EDT(-0400)] <athena> ok
[11:47:46 EDT(-0400)] <athena> will do!
[11:50:25 EDT(-0400)] <holdorph> it could always be a configurable option
[11:50:53 EDT(-0400)] <EricDalquist> seems like it may be a decent question for gary
[11:51:06 EDT(-0400)] <EricDalquist> present the problem of the different ways to persist these values
[11:51:13 EDT(-0400)] <EricDalquist> see if he has any ideas for a UI
[11:51:39 EDT(-0400)] <EricDalquist> perhaps in the CPD add an allowEmpty="true|false" attribute to prefs
[11:51:47 EDT(-0400)] <holdorph> well even if it was just an option at a configuration file level for now. Always leaves room for changing it later
[11:52:25 EDT(-0400)] <holdorph> that would be convenient. i was just hoping for a minimum of an portal wide configuration, but a config per CPD would be even better
[11:53:09 EDT(-0400)] <EricDalquist> I was thinking once per <pref> attribute in a CPD
[11:53:15 EDT(-0400)] <athena> we'd need more than just allowEmpty, since that might imply more of a "required" semantic
[11:53:21 EDT(-0400)] <EricDalquist> but I don't know the code
[11:53:45 EDT(-0400)] <EricDalquist> is that too big to look at that level of config athena?{color}
[11:53:46 EDT(-0400)] <holdorph> storeEmpty
[11:53:47 EDT(-0400)] <athena> i'm hesitant to add things we're not sure we need to the prefs stuff
[11:53:55 EDT(-0400)] <athena> yeah that's probably a better name holdorph
[11:54:04 EDT(-0400)] <athena> the pref and parameter handling code is already horrifically complicated
[11:54:24 EDT(-0400)] <EricDalquist> uhg
[11:54:26 EDT(-0400)] <athena> yeah
[11:56:02 EDT(-0400)] * Sememmon (n=Sememmon@98.174.242.39) has joined ##uportal
[13:00:39 EDT(-0400)] <EricDalquist> grr
[13:00:53 EDT(-0400)] <EricDalquist> IChannelDefinition and IPortletDefinition really should be the same object
[13:01:13 EDT(-0400)] <athena> yeah
[13:01:16 EDT(-0400)] * athena agrees
[13:01:28 EDT(-0400)] <EricDalquist> the JPA relationship mapping is driving me a little nuts
[13:01:48 EDT(-0400)] <athena> if all the preferences get removed for a portlet preference, do you expect the row in up_portlet_pref to be deleted?
[13:02:17 EDT(-0400)] <EricDalquist> if all the values?
[13:02:34 EDT(-0400)] <athena> er, yes, that
[13:02:35 EDT(-0400)] <athena> sorry
[13:02:49 EDT(-0400)] <EricDalquist> no
[13:02:57 EDT(-0400)] <EricDalquist> you can have a preference key with no values
[13:03:09 EDT(-0400)] <EricDalquist> you get a String[0] from the API
[13:03:15 EDT(-0400)] <athena> yeah
[13:08:14 EDT(-0400)] <EricDalquist> I wonder if I could make PortletDefinitionImpl also just implement IChannelDefinition and do away with the actual channel def object
[13:13:40 EDT(-0400)] * Sememmon_ (n=Sememmon@wsip-98-174-242-39.ph.ph.cox.net) has joined ##uportal
[13:15:48 EDT(-0400)] <athena> dunno
[13:16:14 EDT(-0400)] <athena> are you looking to do some inheritance in the database table?
[13:16:36 EDT(-0400)] <athena> or just have blank values for portlet def properties?
[13:16:46 EDT(-0400)] * lennard1 (n=sparhk@wsip-98-174-242-39.ph.ph.cox.net) has joined ##uportal
[13:17:06 EDT(-0400)] <EricDalquist> thinking of actually merging the two objects so we have one less DB table
[13:46:21 EDT(-0400)] <athena> EricDalquist - do you remember what the PORTLET_URL_REWRITE_STATES is and where it comes from?
[13:46:39 EDT(-0400)] <EricDalquist> huh?
[13:47:46 EDT(-0400)] <athena> sorry, still looking at web proxy portlet configuration
[13:48:04 EDT(-0400)] <athena> i'm getting a NPE in the PortletUrlFilter
[13:48:17 EDT(-0400)] <athena> which seems to be coming from the line
[13:48:18 EDT(-0400)] <athena> this.urlStateList = pp.getValues(GeneralConfigImpl.PORTLET_URL_REWRITE_STATES, urlStateList);
[13:48:28 EDT(-0400)] <EricDalquist> ah
[13:49:03 EDT(-0400)] <athena> i'm just not sure what that's supposed to represent - i don't see it in the current list of config preferences
[13:49:07 EDT(-0400)] <EricDalquist> so, if I remember correctly the portlet uses two prefs to configure the URLs to be re-written
[13:49:16 EDT(-0400)] <EricDalquist> one is the list of URL regex{color}
[13:49:33 EDT(-0400)] <EricDalquist> the other is the WindowState to be used for URLs that match the corresponding RegEx
[13:50:10 EDT(-0400)] <athena> interesting
[13:50:27 EDT(-0400)] <athena> looks like that second param fell out of both the documentation and the CPD
[13:50:38 EDT(-0400)] <athena> is there an example anywhere of a reasonable value for it?
[13:50:54 EDT(-0400)] <EricDalquist> NORMAL
[13:50:58 EDT(-0400)] <EricDalquist> MINIMIZED
[13:51:01 EDT(-0400)] <EricDalquist> etc
[13:51:31 EDT(-0400)] <athena> ah ok
[13:51:39 EDT(-0400)]

<EricDalquist> so if you have a list of URL regex like {".*\.google\.com", "my\.wisc\.edu"}

<EricDalquist> I'd have a corresponding state list of {"NORMAL", "MAXIMIZED"}