Page Comparison

[04:18:15 CDT(-0500)] * Topic is 'http://uportal.pastebin.com/ - http://www.ja-sig.org/wiki/display/UPC/uportal+IRC+Logs' set by EricDalquist on 11:32:13 CST(-0600)
[09:26:07 CDT(-0500)] <b-rock_> Greetings uPortal devs: Is the mobile theme muniversality in 3.2.2 enabled by default or is there a configuration change you need to do to enable it? asking because I'm using an android emulator and the portal seems to load the same as in a web browser.
[10:36:20 CDT(-0500)] <athena> b-rock_: it's enabled by default
[10:36:47 CDT(-0500)] <athena> i'm not quite sure why you're not getting the right theme, but check the user agent of the android emulator against the browser.mappings file
[10:37:05 CDT(-0500)] <b-rock_> ok. thanks athena I'll have a look there.
[10:37:10 CDT(-0500)] <athena> yep!
[10:37:15 CDT(-0500)] <athena> let me know if there's something we need to update
[10:37:27 CDT(-0500)] <b-rock_> ok
[12:11:34 CDT(-0500)] <athena> looks like the tab name doesn't get updated until you log in again right now
[12:11:43 CDT(-0500)] <athena> not sure if that's related to the java code or if it's a caching issue
[12:11:53 CDT(-0500)] <EricDalquist> yeah I'm seeing that too
[12:11:57 CDT(-0500)] <EricDalquist> in 3.2
[12:14:43 CDT(-0500)] <EricDalquist> I think it may have to do with my switching the code to display title instead of name
[12:14:54 CDT(-0500)] <EricDalquist> though I haven't really looked at all yet
[12:25:16 CDT(-0500)] <EricDalquist> still waiting on the pluto release process to work through. stuff has changed since the last time I did it so I'm waiting on some help from the other devs
[13:34:24 CDT(-0500)] <athena> aww, no fun
[13:42:19 CDT(-0500)] <athena> so i was taking a look at https://issues.jasig.org/browse/UP-2155
[13:42:29 CDT(-0500)] <athena> i'm not 100% sure what needs to be fixed
[13:42:41 CDT(-0500)] <EricDalquist> PAGs in general
[13:42:44 CDT(-0500)] <athena> lol
[13:42:48 CDT(-0500)] <athena> well, to address the ticket
[13:42:53 CDT(-0500)] <athena> i guess we need to make sure each tester supports multi-valued attributes
[13:42:58 CDT(-0500)] <athena> but it's not completely clear what that means
[13:43:08 CDT(-0500)] <athena> particularly if we want AND or OR support
[13:43:38 CDT(-0500)] <athena> like the ValueMissingTester you wrote looks like it's in good shape
[13:43:54 CDT(-0500)] <athena> but the StringTester just does:
[13:43:57 CDT(-0500)] <athena> if ( atts != null )
[13:43:58 CDT(-0500)] <athena> {
[13:43:58 CDT(-0500)] <athena> for (int i=0; i<atts.length && result == false; i++)
[13:43:58 CDT(-0500)] <athena> {
[13:43:58 CDT(-0500)] <athena> String att = (String)atts[i];
[13:43:58 CDT(-0500)] <athena> result = test(att);
[13:43:58 CDT(-0500)] <athena> }
[13:43:59 CDT(-0500)] <athena> }
[13:44:00 CDT(-0500)] <athena> return result;
[13:44:06 CDT(-0500)] <athena> so i guess you'd just get the result of the last attribute
[13:44:19 CDT(-0500)] <EricDalquist> yeah
[13:44:28 CDT(-0500)] <EricDalquist> I'd assume we would always want to treat multiple values as OR
[13:44:40 CDT(-0500)] <EricDalquist> really we just need a big SpEL Group service in trunk
[13:44:45 CDT(-0500)] <athena> that'd be awesome
[13:44:54 CDT(-0500)] <EricDalquist> just write SpEL to define your groups based on both other groups and attributes
[13:44:56 CDT(-0500)] <EricDalquist> magic!
[13:45:04 CDT(-0500)] <athena> for now to resolve the ticket do you wnat me to just go through and add OR support for StringTester and IntegerTester?
[13:45:10 CDT(-0500)] <athena> i think most stuff inherits from those
[13:45:18 CDT(-0500)] <athena> and yes that would be completely awesome
[13:45:25 CDT(-0500)] <EricDalquist> yeah
[13:45:30 CDT(-0500)] <athena> ok
[13:45:31 CDT(-0500)] <EricDalquist> seems reasonable