Page Comparison

[12:52:03 CDT(-0500)] <athena> is the ehcache issue fixed in the latest release of the resource server?
[12:52:09 CDT(-0500)] <EricDalquist> yeah
[12:52:17 CDT(-0500)] <EricDalquist> I just released 1.0.11 with those fixes
[12:52:19 CDT(-0500)] <athena> awesome
[12:52:19 CDT(-0500)] <EricDalquist> since I needed it
[12:52:29 CDT(-0500)] <EricDalquist> I moved the fluid changes issue to 1.0.12
[12:52:38 CDT(-0500)] <EricDalquist> so whenever you and awills get to that you can cut that version
[12:52:40 CDT(-0500)] <athena> wondering if we should modify our jquery calls a bit - 1.4 started supporting etags apparently, but it's turned off by default
[12:52:55 CDT(-0500)] <athena> seems like you should only have to download the channel list and such if the etag doesn't match
[12:53:01 CDT(-0500)] <EricDalquist> nice
[12:53:27 CDT(-0500)] <athena> ah, didn't realize awills hadn't added those
[12:53:56 CDT(-0500)] <EricDalquist> that that I had seen in the commit logs at least
[12:54:08 CDT(-0500)] <EricDalquist> https://issues.jasig.org/browse/RESSERV-7 exists to track that
[12:55:21 CDT(-0500)] <athena> sounds good
[12:56:01 CDT(-0500)] <EricDalquist> also the resource server doesn't have a background thread anymore
[12:56:14 CDT(-0500)] <EricDalquist> somehow we overlooked the setDateHeader(String, int) API
[12:56:22 CDT(-0500)] <EricDalquist> which does the data formatting for you in the servlet container
[12:56:29 CDT(-0500)] <EricDalquist> er date formattingh
[13:00:37 CDT(-0500)] <EricDalquist> oh athena did you ever get the no content for / figured out in trunk?
[13:00:40 CDT(-0500)] <EricDalquist> or are you still seeing that?
[13:01:49 CDT(-0500)] <athena> about to start up again
[13:01:54 CDT(-0500)] <athena> running a clean build
[13:02:08 CDT(-0500)] <EricDalquist> ok
[13:09:34 CDT(-0500)] <athena> woooo it works now
[13:09:39 CDT(-0500)] <EricDalquist> yay
[13:09:39 CDT(-0500)] <athena> errr
[13:09:40 CDT(-0500)] <athena> never mind
[13:09:42 CDT(-0500)] <athena> that's uportal 3.2
[13:09:45 CDT(-0500)] <EricDalquist> uhoh
[13:09:45 CDT(-0500)] <EricDalquist> lol
[13:09:57 CDT(-0500)] <athena> lol
[13:10:01 CDT(-0500)] * athena is super tired
[13:17:57 CDT(-0500)] <athena> ok EricDalquist
[13:18:03 CDT(-0500)] <athena> here's what i'm getting: http://uportal.pastebin.com/7Qi0g4cb
[13:18:20 CDT(-0500)] <EricDalquist> did you grab the commit I did yesterday?
[13:18:25 CDT(-0500)] <athena> yeah
[13:18:38 CDT(-0500)] <athena> so the page finishes rendering now
[13:18:47 CDT(-0500)] <athena> err
[13:18:49 CDT(-0500)] <athena> actually, it doesn't
[13:18:50 CDT(-0500)] <athena> hm
[13:19:21 CDT(-0500)] <EricDalquist> yeah it probably stops there
[13:19:38 CDT(-0500)] <athena> so which was the commit yesterday for?
[13:20:02 CDT(-0500)] <EricDalquist> it should have been a fix so that if a portlet failed to render it would return "" instead of null for content
[13:20:37 CDT(-0500)] <EricDalquist> I don't have the code in front of me
[13:20:38 CDT(-0500)] <athena> ah
[13:20:44 CDT(-0500)] <EricDalquist> what is it doing here: PortletRenderingIncorporationComponent.java:106
[13:21:21 CDT(-0500)] <EricDalquist> ah
[13:21:26 CDT(-0500)] <athena> return new CharacterDataEventImpl(title);
[13:21:27 CDT(-0500)] <EricDalquist> apparently I only fixed content
[13:21:28 CDT(-0500)] <EricDalquist> not title
[13:21:29 CDT(-0500)] <EricDalquist> yeah
[13:22:06 CDT(-0500)] <athena> ah ok
[13:22:08 CDT(-0500)] <EricDalquist> so in PortletExecutionManager
[13:22:09 CDT(-0500)] <EricDalquist> line 301
[13:22:13 CDT(-0500)] <athena> so getPortletTItle needs a fix?
[13:22:13 CDT(-0500)] <EricDalquist> change
[13:22:13 CDT(-0500)] <EricDalquist> return portletRenderResult.getTitle();
[13:22:32 CDT(-0500)] <EricDalquist> to:
[13:22:32 CDT(-0500)] <EricDalquist> final String title = portletRenderResult.getTitle();
[13:22:32 CDT(-0500)] <EricDalquist> return title != null ? title : "";
[13:22:56 CDT(-0500)] <athena> gotcha
[13:23:06 CDT(-0500)] <athena> thanks
[13:23:17 CDT(-0500)] <athena> so it looks like our controllers aren't setting many headers
[13:23:23 CDT(-0500)] <athena> don't see any etags, modified, etc.
[13:23:50 CDT(-0500)] <EricDalquist> right
[13:24:04 CDT(-0500)] <EricDalquist> we can't really set an etag for .uP requests yet
[13:24:19 CDT(-0500)] <EricDalquist> we don't have enough state information until portlet caching is implemented
[13:24:36 CDT(-0500)] <EricDalquist> all the .uP calls should be getting essentially no-cache headers set though
[13:24:43 CDT(-0500)] <EricDalquist> the ajax controllers however
[13:24:46 CDT(-0500)] <EricDalquist> I have no idea
[13:24:52 CDT(-0500)] <EricDalquist> but I have to run ... be back on in ~ an hour
[13:24:56 CDT(-0500)] <athena> ok
[13:25:15 CDT(-0500)] <athena> talk to you in a bit
[15:54:08 CDT(-0500)] <athena> wasn't a big deal - just needed to return "" instead of null when it hit exceptions getting the portlet window
[15:54:15 CDT(-0500)] <EricDalquist1> yeah
[15:54:34 CDT(-0500)] <EricDalquist1> Nick & I will be working on a new ErrorPortlet on Thursday
[15:54:45 CDT(-0500)] <EricDalquist1> which will hopefully make things easier
[16:15:39 CDT(-0500)] <EricDalquist1> athena: working on updating the browser.mapping handling code
[16:15:55 CDT(-0500)] <athena> oh nice!
[16:16:00 CDT(-0500)] <EricDalquist1> thinking about basic requirements, do we need anything more than what was there?
[16:16:17 CDT(-0500)] <EricDalquist1> ordered regex->profile mappings
[16:18:04 CDT(-0500)] <athena> hmm
[16:18:09 CDT(-0500)] <athena> not that i've thought of offhand
[16:18:19 CDT(-0500)] <EricDalquist1> my current plan is a simple class that takes the list of mappings
[16:18:22 CDT(-0500)] <EricDalquist1> and a default profile id
[16:18:28 CDT(-0500)] <EricDalquist1> so we don't have to have the .* mapping
[16:58:27 CDT(-0500)] <athena> that makes a lot of sense