[10:18:36 EDT(-0400)] * EricDalquist (n=dalquist@bohemia.doit.wisc.edu) has joined ##uportal
[10:38:55 EDT(-0400)] * esm (n=esm@clue.mse.jhu.edu) has joined ##uportal
[13:06:16 EDT(-0400)] <EricDalquist> I eventually want to get some findbug rules for catching but not logging or chaining exceptions
[13:10:08 EDT(-0400)] <esm> I think i have a PMD rule for that
[13:10:14 EDT(-0400)] <esm> i don't know how PMD compares to findbug
[13:10:26 EDT(-0400)] <EricDalquist> well pmd
[13:10:51 EDT(-0400)] <EricDalquist> as I clean up the exception code I'm finding all sorts of log.error(msg + e);
[13:10:59 EDT(-0400)] <esm> 
[13:11:06 EDT(-0400)] <EricDalquist> and throw new Exception(msg + e)
[13:11:12 EDT(-0400)] <EricDalquist> or just not using the cause at all
[13:11:32 EDT(-0400)] <esm> nice
[13:57:18 EDT(-0400)] <esm> if a factory isn't being used, should/can it be removed?
[13:57:31 EDT(-0400)] <EricDalquist> yeah, feel free to remove 'dead' code
[13:57:44 EDT(-0400)] <esm> org.jasig.portal.rendering.sax.xslt.StylesheetIdFactory
[13:57:48 EDT(-0400)] <esm> i think that is dead
[13:58:37 EDT(-0400)] <EricDalquist> looks like it
[13:58:56 EDT(-0400)] <EricDalquist> I just did a complete search and the only place 'StylesheetIdFactory' is in the file itself
[13:59:16 EDT(-0400)] <esm> yeah same here
[13:59:21 EDT(-0400)] <EricDalquist> I just finished the exception cleanup on trunk
[13:59:38 EDT(-0400)] <EricDalquist> I'm going to be mergeing it into the two active branches in the next bit
[13:59:47 EDT(-0400)] <EricDalquist> we shouldn't see any more
[13:59:55 EDT(-0400)] Wiki Markup <EricDalquist> "{0}" exceptions
[14:02:26 EDT(-0400)] <esm> cool
[14:09:27 EDT(-0400)] <esm> ids would be much easier if there wasn't the class heirarchy
[14:09:52 EDT(-0400)] <esm> functionally IUserId.createUserId(int) is the same as ObjectId.createId(int)
[14:10:00 EDT(-0400)] <EricDalquist> yeah :/
[14:10:11 EDT(-0400)] <EricDalquist> I'm not sure if there is a good way to deal with all of that
[14:11:07 EDT(-0400)] <esm> oh well, for another day.
[14:11:16 EDT(-0400)] <EricDalquist> yup :/
[14:18:33 EDT(-0400)] <esm> hey is there a permissions or workflow issue with the ja-sig jira? or maybe i'm missing something...
[14:18:39 EDT(-0400)] <esm> how do you close/resolve a subtask
[14:18:58 EDT(-0400)] <EricDalquist> which task (so I can see an example)
[14:19:16 EDT(-0400)] <esm> All I can do, under "Available Workflow Actions" is "Start Progress". For example http://www.ja-sig.org/issues/browse/UPT-289
[14:19:36 EDT(-0400)] <esm> Same with http://www.ja-sig.org/issues/browse/UPT-268
[14:19:38 EDT(-0400)] <EricDalquist> ah
[14:19:39 EDT(-0400)] <EricDalquist> yeah
[14:19:43 EDT(-0400)] <EricDalquist> you're just a 'user'
[14:19:46 EDT(-0400)] <EricDalquist> just a sec
[14:19:48 EDT(-0400)] <esm>
[14:19:55 EDT(-0400)] <esm> ty
[14:19:56 EDT(-0400)] <EricDalquist> ok
[14:20:02 EDT(-0400)] <EricDalquist> you're in uportal-dev now
[14:20:43 EDT(-0400)] <esm> Nice! thanks it works
[14:26:17 EDT(-0400)] <EricDalquist> cool
[14:40:01 EDT(-0400)] <EricDalquist> ok
[14:40:13 EDT(-0400)] <EricDalquist> updated exception code in trunk and both branches
[14:40:13 EDT(-0400)] <EricDalquist> brb
[14:44:29 EDT(-0400)] <EricDalquist> back ...
[14:45:21 EDT(-0400)] <EricDalquist> so pluto 1.1.3 is out now?
[14:47:59 EDT(-0400)] <EricDalquist> of course the caching work I started on friday is on my peronal laptop ... at home
[14:56:47 EDT(-0400)] <EricDalquist> hrm ... appears to have been an API change in plutu from 1.1.1 to 1.1.3
[14:56:58 EDT(-0400)] <esm> ?
[14:57:09 EDT(-0400)] <EricDalquist> Severity and Description Path Resource Location Creation Time Id
[14:57:09 EDT(-0400)] <EricDalquist> The type PortletUrlProviderImpl must implement the inherited abstract method PortletURLProvider.isSecureSupported() uPortal_3.0.0/uportal3-impl/src/main/java/org/jasig/portal/portlet/container/services PortletUrlProviderImpl.java line 31 1175540201187 1286886
[14:57:09 EDT(-0400)] <EricDalquist> The type SimplePortalAdministrationService must implement the inherited abstract method PortalAdministrationService.getPortletInvocationListeners() uPortal_3.0.0/uportal3-impl/src/main/java/org/jasig/portal/portlet/container/services SimplePortalAdministrationService.java line 18 1175540201187 1286884
[14:57:10 EDT(-0400)] <esm> where at?
[14:57:11 EDT(-0400)] <EricDalquist> ack
[14:57:14 EDT(-0400)] <EricDalquist> that was ugly
[14:57:25 EDT(-0400)] <EricDalquist> The type PortletUrlProviderImpl must implement the inherited abstract method PortletURLProvider.isSecureSupported()
[14:57:32 EDT(-0400)] <esm> ugh.
[14:57:36 EDT(-0400)] <EricDalquist> The type SimplePortalAdministrationService must implement the inherited abstract method PortalAdministrationService.getPortletInvocationListeners()
[14:57:59 EDT(-0400)] <EricDalquist> two new methods on interfaces/abstract classes
[14:58:06 EDT(-0400)] <esm> yep.
[14:58:59 EDT(-0400)] <esm> but 1.1.1 and 1.1.3 are binary compat
[14:59:05 EDT(-0400)] <EricDalquist> oops
[14:59:25 EDT(-0400)] <EricDalquist> I'll try to try out the new pluto releases in the future to see if I catch more of that
[14:59:35 EDT(-0400)] <EricDalquist> since uP3 has its hooks fairly deep into pluto
[14:59:51 EDT(-0400)] <esm> right. I'll have to ping the list on the policy
[15:00:09 EDT(-0400)] <esm> b/c 1.1.3 is a drop-in replacement as a jar
[15:00:22 EDT(-0400)] <EricDalquist> ok, well if you need me to chime in at all let me know
[15:00:30 EDT(-0400)] <esm> definitly I will
[15:00:35 EDT(-0400)] <esm> i'll post a message today
[15:43:23 EDT(-0400)] <EricDalquist> I'm out ... going to a home inspection
[16:23:16 EDT(-0400)] <esm> hey eric, if you check your scrollback... are we doing one massive merge from maven-refactor to maven-mod, or are we merging commit by commit? I'm beginning to think that one massive merge from maven-refactor to maven-mod will be easiest.
[16:23:25 EDT(-0400)] <esm> let meknow your thoughts
[16:23:31 EDT(-0400)] * esm (n=esm@clue.mse.jhu.edu) has left ##uportal
[18:06:59 EDT(-0400)] * EricDalqui[away] (n=dalquist@bohemia.doit.wisc.edu) has joined ##uportal
Page Comparison
General
Content
Integrations