Page Comparison

[04:33:19 CST(-0600)] <rickard> Hmm. It appears uPortal ignores anything I put into UP_CHANNEL_MDATA.
[04:33:38 CST(-0600)] <rickard> I'm trying to localize channel names.
[04:34:18 CST(-0600)] <rickard> I've read online that CHAN_NAME needs to match CHAN_NAME from UP_CHANNEL and it does, but I still can't get it to work.
[04:50:43 CST(-0600)] <rickard> athena: You there?
[09:35:49 CST(-0600)] <athena> hi rickard
[09:35:57 CST(-0600)] <athena> i was not in fact here
[09:36:03 CST(-0600)] * athena lives on the west coast of the US
[09:40:11 CST(-0600)] <rickard> athena: That explains it
[09:40:17 CST(-0600)] <athena> lol yes
[09:40:39 CST(-0600)] <rickard> I don't want to bug you, but did you by any chance see my post on the mailing list regarding the up_channel_mdata?
[09:40:52 CST(-0600)] <rickard> You seem to know your way around the code.
[09:41:17 CST(-0600)] <athena> looking
[09:41:56 CST(-0600)] <athena> i'm not sure the code to use the MDATA stuff exists/works anymore :/
[09:42:05 CST(-0600)] <athena> to be perfectly honest
[09:42:13 CST(-0600)] <rickard> Ok
[09:42:28 CST(-0600)] <athena> we've been talking about updating / rewriting all of that for the upcoming release of uportal, which should have a lot of i18n fixes
[09:42:29 CST(-0600)] <rickard> If that's true, that would explain why it doesn't get picked up
[09:42:52 CST(-0600)] <athena> yeah, i have a feeling it may have gotten lost somewhere
[09:42:54 CST(-0600)] <rickard> Yeah, I've read some discussions on the subject, but I thought that was for 3.3.
[09:43:14 CST(-0600)] <athena> you might be able to fix it by making theme/structure modifications
[09:43:20 CST(-0600)] <athena> yeah, all those fixes will be for 3.3
[09:43:53 CST(-0600)] <rickard> Yeah, that's what we do today. We add it to messages.xml and then do a lookup on the channel name before we output it.
[09:44:03 CST(-0600)] <athena> gotcha
[09:44:11 CST(-0600)] <athena> if you look at channeldefinitionimpl there are messages like getName(String locale)
[09:44:13 CST(-0600)] <rickard> But it's not the most elegant solution in that it requires us to modify the theme whenever we make a change.
[09:44:26 CST(-0600)] <athena> but i'm not sure if the layout ever actually gets those locales
[09:44:44 CST(-0600)] <athena> eric might know a bit more
[09:45:44 CST(-0600)] <rickard> Ok
[09:46:45 CST(-0600)] <rickard> There is a locale attribute on channel in the theme xml, but for some reason, it's set to en_US on some channels and sv_SE on others. Regardless, the channel titles and stuff are still in English.
[09:47:11 CST(-0600)] <rickard> I'll see if Eric is here tomorrow. Maybe he knows something.
[09:47:20 CST(-0600)] <athena> yeah, asking him wouldn't be a bad idea
[09:47:33 CST(-0600)] <rickard> How is 3.2.5 coming along?
[09:47:41 CST(-0600)] <athena> also a question for eric
[09:47:45 CST(-0600)] <rickard>
[09:47:57 CST(-0600)] <athena> i know there are some good fixes out there, but i'm not quite sure what else might be planned for that release
[09:48:02 CST(-0600)] <rickard> There's a pretty big list of unresolved bugs for 3.2.5 in Jira. Can't imagine all of them will be closed before release.
[09:48:09 CST(-0600)] <athena> agreed
[09:48:22 CST(-0600)] <athena> and probably some of them aren't very high priority
[09:48:27 CST(-0600)] <rickard> True
[09:49:10 CST(-0600)] <rickard> Another issue with i18n is that the locale switcher doesn't seem to work for guests.
[09:49:17 CST(-0600)] <athena> yes, that is absolutely true
[09:49:27 CST(-0600)] <rickard> On the list for 3.3?
[09:49:29 CST(-0600)] <athena> yes
[09:49:42 CST(-0600)] <athena> should be easier to fix with the rendering pipeline changes there
[09:49:46 CST(-0600)] <rickard> Ok
[09:49:51 CST(-0600)] <rickard> I won't bug you anymore. Thanks.
[09:50:00 CST(-0600)] <athena> i'd really like uportal's i18n support to be more solid as of 3.3 - i imagine it's kind of frustrating right now
[09:50:04 CST(-0600)] <athena> no problem
[09:50:10 CST(-0600)] <rickard> Yeah, it is.
[09:52:03 CST(-0600)] <rickard> The documentation on the subject is also a bit dated. I found references to stuff from like 2002 that surely no longer applies.
[09:52:55 CST(-0600)] <athena> well, we do have a documentation coordinator now, so if you find documentation that needs to be fixed in the manual, you might let her know
[09:53:13 CST(-0600)] <athena> all the current efforts are taking place at https://wiki.jasig.org/display/UPM32/Home
[09:53:35 CST(-0600)] <rickard> Yup
[09:53:44 CST(-0600)] <rickard> I've been working with this: https://wiki.jasig.org/display/UPC/Minimal+guide+for+Internationalization
[09:53:56 CST(-0600)] <rickard> But I guess it no longer applies.
[09:54:40 CST(-0600)] <athena> i guess step 1 does, but from what you're saying it sounds like step 2 doesn't work
[09:54:44 CST(-0600)] <athena> wonder how hard it would be to fix
[09:55:14 CST(-0600)] <rickard> Thing is, even if that is fixed, tabs still need to be localized in the theme.
[09:55:20 CST(-0600)] <athena> i know
[09:55:30 CST(-0600)] <athena> and i don't know if we'll be able to get that done for 3.3
[09:55:53 CST(-0600)] <athena> here's the wish list / planning page we have set up at the moment: https://wiki.jasig.org/display/UPC/Improving+uPortal+i18n+Support
[09:57:00 CST(-0600)] <rickard> Yeah, I saw that today.
[09:57:02 CST(-0600)] <rickard> "i18n support for tab names"
[09:57:53 CST(-0600)] <rickard> The up_channel_mdata solution seems ok to me. Wouldn't something similar be doable for tabs?
[09:58:06 CST(-0600)] <rickard> Or are tabs not store in the database like channels?
[09:58:11 CST(-0600)] <rickard> stored even
[09:58:35 CST(-0600)] <athena> they are not, unfortunately
[09:58:59 CST(-0600)] <athena> hey EricDalquist
[09:59:04 CST(-0600)] <EricDalquist> hello
[09:59:06 CST(-0600)] <rickard> howdy
[10:06:03 CST(-0600)] <rickard> EricDalquist: Did you by any chance see my post on the mailing list regarding up_channel_mdata?
[10:06:22 CST(-0600)] <rickard> athena tells me that he isn't certain if the mdata stuff exists/works anymore.
[10:06:29 CST(-0600)] <EricDalquist> not yet, on a phone call for the next hour...
[10:06:38 CST(-0600)] <rickard> Ok. No rush.
[10:06:49 CST(-0600)] <rickard> I'm leaving for the day in a few minutes anyway.
[11:23:51 CST(-0600)] <EricDalquist> athena: I have some ideas of what is happening with the mobile view
[11:24:00 CST(-0600)] <athena> oooh
[11:24:18 CST(-0600)] <EricDalquist> it appears to be initiating rendering of the portlets when just viewing the list of portlets
[11:24:34 CST(-0600)] <athena> interesting
[11:24:53 CST(-0600)] <EricDalquist> but since there are never incorperated into the post-theme content the portal doesn't wait for them to finish
[11:24:57 CST(-0600)] <EricDalquist> so we see all sorts of errors
[11:25:18 CST(-0600)] <EricDalquist> does the mobile structure XSL write them out as <channel> elements?
[11:25:43 CST(-0600)] <EricDalquist> yeah it does
[11:25:51 CST(-0600)] <athena> i honestly have no idea - i think matt wrote most fo the structure
[11:25:53 CST(-0600)] <athena> ah
[11:26:01 CST(-0600)] <athena> interesting
[11:26:01 CST(-0600)] <EricDalquist> any <channel> element written out by the structure will result in that channel being rendered
[11:26:09 CST(-0600)] <athena> i did not know thta
[11:26:11 CST(-0600)] <EricDalquist> that happens async
[11:26:12 CST(-0600)] <athena> makes sense though
[11:26:15 CST(-0600)] <EricDalquist> they get started
[11:26:20 CST(-0600)] <athena> so hopefully this is something we can fix pretty easily?
[11:26:25 CST(-0600)] <EricDalquist> well
[11:26:33 CST(-0600)] <EricDalquist> we'll have to modify the mobile structure & theme
[11:26:37 CST(-0600)] <athena> yeah
[11:26:46 CST(-0600)] <athena> only include the channel when in focus mode, basically?
[11:26:48 CST(-0600)] <EricDalquist> so in the channel list view we're writing out something like <channel-link>
[11:26:53 CST(-0600)] <athena> then have a way to have the titles in, but not the channels
[11:26:54 CST(-0600)] <EricDalquist> yup
[11:27:08 CST(-0600)] <EricDalquist> brb
[11:27:10 CST(-0600)] <athena> ok
[11:31:08 CST(-0600)] <EricDalquist> yeah so I'll take a crack at that this morning
[11:47:19 CST(-0600)] <awills> oh hello EricDalquist, good to see you
[11:48:08 CST(-0600)] <awills> would be happy to discuss header/footer fragment content in real time
[12:26:26 CST(-0600)] <EricDalquist> heh, yeah this mobile XSL issue should make the mobile view a lot faster too
[12:26:35 CST(-0600)] <EricDalquist> it was rendering every portlet in a user's layout on every request
[12:26:41 CST(-0600)] <EricDalquist> granted it wasn't waiting for them
[12:29:33 CST(-0600)] <athena> eep!
[12:29:38 CST(-0600)] <athena> really glad you tracked that down
[12:29:40 CST(-0600)] <athena> i would not have found that
[12:29:53 CST(-0600)] <athena> awills: you following the mobile issue?
[12:30:09 CST(-0600)] <EricDalquist> yeah so the rendering pipline (in all versions) will start rendering every <channel> output by the structure
[12:30:42 CST(-0600)] <EricDalquist> then incorporate the output of <channel> output by the theme XSL
[12:30:51 CST(-0600)] <athena> gotcha
[12:31:03 CST(-0600)] <EricDalquist> the problem in the mobile ui is it is writing out <channel> elements just for navigation
[12:31:20 CST(-0600)] <EricDalquist> that is why the flyouts use <tabChannel> and not <channel>
[12:31:22 CST(-0600)] <EricDalquist> to avoid this issue
[12:31:27 CST(-0600)] <athena> makes sense
[12:31:34 CST(-0600)] <athena> seems like we can fix that pretty easily
[12:31:39 CST(-0600)] <EricDalquist> yeah
[12:31:42 CST(-0600)] <EricDalquist> working on that right now
[12:31:49 CST(-0600)] <EricDalquist> should only be a few places that need fixing
[12:33:43 CST(-0600)] <EricDalquist> dangit, I always forget to turn off the iphone useragent in firefox
[12:33:51 CST(-0600)] <EricDalquist> and then get confused when I go to other sites
[12:34:14 CST(-0600)] <athena> lol
[12:34:16 CST(-0600)] <athena> me too
[12:38:05 CST(-0600)] <awills> athena catching up
[12:38:30 CST(-0600)] <awills> sounds like a good catch... important fix
[12:38:47 CST(-0600)] <athena> absolutely
[12:38:58 CST(-0600)] <athena> i'd determined yesterday that my previous patch didnt' fix the issue
[12:39:04 CST(-0600)] <athena> it's really hard to reliably trigger the bug
[12:40:13 CST(-0600)] <EricDalquist> well I still haven't seen that bug
[12:40:19 CST(-0600)] <EricDalquist> but I'm not going to dig more until this is fixed
[12:40:25 CST(-0600)] <EricDalquist> because it could very well be a side effect
[12:40:28 CST(-0600)] <athena> no that sounds like a reasonable candidate
[12:40:46 CST(-0600)] <athena> and should address that anyway
[12:45:21 CST(-0600)] <EricDalquist> not sure why but xslt/xpath makes me happy
[12:46:38 CST(-0600)] <athena> lol
[12:46:47 CST(-0600)] <athena> i think i'm less enthusiastic
[12:46:55 CST(-0600)] <athena> though as long as you're not doing something awful it's fine
[12:47:34 CST(-0600)] <athena> i think some of the work we did a few years ago with trying to render links for moving tabs based on permissions and priorities of the tabs before and after broke some small piece of my soul
[12:47:40 CST(-0600)] <awills> you might be in the minority on that one... though I can support the notion that XPath is satisfying
[12:47:45 CST(-0600)] <athena> it's yet to really forgive XSLT for that
[12:47:59 CST(-0600)] <athena> however using XPath type stuff in jQuery makes me happy
[12:47:59 CST(-0600)] <EricDalquist> I think it is nostalgia, my first programming job in college was 25% java 75% XSLT
[12:48:06 CST(-0600)] <EricDalquist> and we did some crazy stuff in XSL
[12:48:08 CST(-0600)] <athena> ah
[13:01:41 CST(-0600)] <EricDalquist> trying the fix now ... I just renamed channel to channel-nav for the navigation XML
[13:04:17 CST(-0600)] <EricDalquist> yay that works
[13:10:16 CST(-0600)] <EricDalquist> hrm
[13:10:21 CST(-0600)] <EricDalquist> another thing with the mobile UI I noticed
[13:10:35 CST(-0600)] <EricDalquist> when you hit back then refresh you get the portlet again
[13:16:20 CST(-0600)] <athena> oh hm, that's an interesting point
[13:16:32 CST(-0600)] <EricDalquist> since the URL is never changed
[13:16:35 CST(-0600)] <athena> guess we could update the current URL via js?
[13:16:38 CST(-0600)] <EricDalquist> right
[13:16:45 CST(-0600)] <EricDalquist> but that can cause a page reload I think
[13:16:49 CST(-0600)] <EricDalquist> you could do what gmail does
[13:16:49 CST(-0600)] <athena> ah
[13:16:53 CST(-0600)] <EricDalquist> and do it via anchors
[13:16:56 CST(-0600)] <athena> thought there was a way to update the URL without reloading
[13:17:03 CST(-0600)] <EricDalquist> maybe
[13:17:09 CST(-0600)] <EricDalquist> I'm not an expert with that stuff
[13:17:12 CST(-0600)] <athena> nor am i
[13:17:19 CST(-0600)] <EricDalquist> I'll file a jira for that when I'm doing the other fixes
[13:17:23 CST(-0600)] <athena> sounds great
[13:17:32 CST(-0600)] <athena> do you want me to look at updating the structure/theme?
[13:17:37 CST(-0600)] <athena> or are you already looking at that?
[13:18:13 CST(-0600)] <rickard> EricDalquist: Thanks for your responses on the mailing list. I think either I'm misunderstanding you or you misunderstood my question regarding hiding a channel when you click on the tab. What I'm after is essentially a channel that will only be displayed in focused mode.
[13:18:29 CST(-0600)] <EricDalquist> how does the user focus the channel?
[13:18:42 CST(-0600)] <rickard> They click on the link in the navigation.
[13:19:05 CST(-0600)] <EricDalquist> ok, so how does the link get there then?
[13:19:10 CST(-0600)] <EricDalquist> do you want that link hardcoded?
[13:19:20 CST(-0600)] <EricDalquist> or there dynamically because the channel is in the user's layout?
[13:20:51 CST(-0600)] <EricDalquist> athena: was there a jira for the mobile view issue?
[13:21:06 CST(-0600)] <athena> there was - we should reopen it
[13:21:19 CST(-0600)] <athena> let me find it
[13:22:33 CST(-0600)] <athena> https://issues.jasig.org/browse/UP-2857
[13:22:54 CST(-0600)] <athena> https://issues.jasig.org/browse/UP-2857
[13:22:58 CST(-0600)] <athena> er, woops
[13:22:59 CST(-0600)] <rickard> EricDalquist: Hmm. When you click on a tab, all the channels in that tab are rendered. However, you can also click on a channel in the navigation (fly-out or the "static" version) to focus that channel. What I want is for specific channels to not be rendered when you click on the tab. Instead, users will have to click on the link to the channel in the navigation.