Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

[14:26:46 CDT(-0500)] <drewwills> yes... very nice

[14:29:22 CDT(-0500)] <EricDalquist> looks good

[14:29:34 CDT(-0500)] <EricDalquist> the only real big functional issue is this one: https://github.com/Jasig/portlet-utils/commit/e1402917529432e63124f58b4e179fbaf5e5f974#L4R170

[14:29:55 CDT(-0500)] <EricDalquist> you could end up with stuff like headers from the portal's rest api response on your app's response

[14:30:11 CDT(-0500)] <EricDalquist> or illegal state exceptions when trying to write out headers to an already committed response