Page Comparison

[00:05:12 EST(-0500)] * Sememmon (n=Sememmon@unaffiliated/sememmon) has joined ##uportal
[00:13:51 EST(-0500)] * lennard1 (n=sparhk@ip68-98-56-21.ph.ph.cox.net) has left ##uportal
[08:52:33 EST(-0500)] * athena (n=athena@adsl-76-250-193-123.dsl.wlfrct.sbcglobal.net) has joined ##uportal
[08:58:49 EST(-0500)] * EricDalquist (n=dalquist@bohemia.doit.wisc.edu) has joined ##uportal
[09:12:07 EST(-0500)] <athena> EricDalquist: i'm cleaning up the skin stuff from yesterday
[09:12:18 EST(-0500)] <EricDalquist> great
[09:12:24 EST(-0500)] <athena> i think i should have it reorganized to better use the resource server in an hour or so
[09:12:31 EST(-0500)] <EricDalquist> sounds good
[09:12:39 EST(-0500)] <athena> i do have a few concerns about the visual changes though
[09:12:47 EST(-0500)] <athena> have you looked at the default skin at all?
[09:13:04 EST(-0500)] <EricDalquist> I haven't looked yet
[09:13:08 EST(-0500)] <athena> ok
[09:13:14 EST(-0500)] <EricDalquist> I have some appointments this morning
[09:13:17 EST(-0500)] <EricDalquist> I'll look when I get back
[09:13:21 EST(-0500)] <athena> sounds good
[09:13:28 EST(-0500)] <athena> there's a new "coal" skin, which is nice to have
[09:13:43 EST(-0500)] <athena> i have some mixed feelings about the changes to the default skin though
[09:13:47 EST(-0500)] <athena> we'll see what you think
[09:13:49 EST(-0500)] <EricDalquist> ok
[09:36:51 EST(-0500)] * michelled (n=michelle@CPE001310472ade-CM0011aefd3ca8.cpe.net.cable.rogers.com) has joined ##uportal
[10:02:41 EST(-0500)] * holdorph (n=holdorph@wsip-72-215-204-133.ph.ph.cox.net) has joined ##uportal
[10:31:16 EST(-0500)] * colinclark (n=colin@142.150.154.101) has joined ##uportal
[11:04:59 EST(-0500)] * lennard1 (n=sparhk@wsip-72-215-204-133.ph.ph.cox.net) has joined ##uportal
[11:15:20 EST(-0500)] * Sememmon (n=Sememmon@unaffiliated/sememmon) has joined ##uportal
[11:28:28 EST(-0500)] <EricDalquist> athena: I see what you mean about the skin changes
[11:28:33 EST(-0500)] <EricDalquist> I like the ideas
[11:28:38 EST(-0500)] <athena> yeah
[11:28:39 EST(-0500)] <EricDalquist> but it doesn't look polished at all
[11:28:42 EST(-0500)] <athena> yeah
[11:28:49 EST(-0500)] <EricDalquist> lots of random table borders too
[11:28:52 EST(-0500)] <athena> cool in theory to have some rounded corners, modern whatever
[11:29:01 EST(-0500)] <athena> yeah, we need to take the borders out - but that's easily fixable
[11:29:17 EST(-0500)] <athena> a bit annoyed because we've talked about that in the past, but whatever, it probably snuck back in accidentally
[11:29:32 EST(-0500)] <athena> but i personally find a lot of the text in the skin hard to read - especially the portlet titles
[11:29:46 EST(-0500)] <athena> and i worry a bit that the portlet borders take up more screen real estate
[11:30:05 EST(-0500)] <athena> the mix of rounded borders and not feels a little inconsistent, too
[11:31:06 EST(-0500)] <EricDalquist> yeah
[11:31:36 EST(-0500)] <EricDalquist> so do we go back and see if Gary has time to do more changes or just revert the changes?
[11:31:42 EST(-0500)] <EricDalquist> the visual changes that is
[11:33:03 EST(-0500)] <athena> the problem is that i think the visual changes and the technical changes are all in the same commit
[11:33:13 EST(-0500)] <EricDalquist> yeah
[11:33:18 EST(-0500)] <EricDalquist> they were
[11:33:21 EST(-0500)] <athena> let me talk to gary and see what he can do
[11:33:44 EST(-0500)] <EricDalquist> ok
[11:34:21 EST(-0500)] <EricDalquist> also in the skin.xml file for some of the skins there are elements that look like:
[11:34:21 EST(-0500)] <EricDalquist> <css type="fss-theme" name="fl-theme-mist">
[11:34:29 EST(-0500)] <EricDalquist> those type and name attributes are ignored
[11:34:37 EST(-0500)] <EricDalquist> so we need to figure out if they are important or not
[11:34:41 EST(-0500)] <athena> yeah i wondered what those were
[11:34:43 EST(-0500)] <athena> i'll ask him
[11:36:16 EST(-0500)] <EricDalquist> oh there are also some skin images 404ing in the default skin
[11:36:39 EST(-0500)] <athena> yeah i saw that
[11:54:35 EST(-0500)] <athena> ok EricDalquist, talked to gary for a whille
[11:54:45 EST(-0500)] <athena> sent him a screenshot so he can see how it looks on my screen
[11:54:55 EST(-0500)] <athena> he said to feel free to ping him with any specific thoughts
[11:55:02 EST(-0500)] <EricDalquist> ok
[11:55:41 EST(-0500)] <EricDalquist> is there anything he's going to be working on right now? If so I'll hold off and wait
[11:56:17 EST(-0500)] <athena> i'd go ahead and send your comments
[11:56:21 EST(-0500)] <EricDalquist> ok
[11:56:29 EST(-0500)] <athena> i know he's going to make the portlet titles darker for sure so that they're more readable
[11:56:44 EST(-0500)] <athena> and then i think take a look and make sure there's not anything that got missed on checkin
[11:57:33 EST(-0500)] <EricDalquist> sounds good
[12:00:43 EST(-0500)] <EricDalquist> hrm
[12:00:50 EST(-0500)] <EricDalquist> does drag and drop work for you?
[12:21:34 EST(-0500)] <EricDalquist> athena: does drag & drop work for you?
[12:21:47 EST(-0500)] <athena> oh, that's a good question
[12:21:49 EST(-0500)] <athena> i haven't tried it
[12:21:54 EST(-0500)] <EricDalquist> it isn't for me
[12:22:01 EST(-0500)] <EricDalquist> and I can't even find the JS that initializes it
[12:22:11 EST(-0500)] <athena> uhoh!
[12:22:14 EST(-0500)] <athena> i'll take a look
[12:25:09 EST(-0500)] <EricDalquist> do you know which XSL file had the d&d init code in it?
[12:25:46 EST(-0500)] <athena> ok, i found the problem
[12:25:54 EST(-0500)] <athena> the d&d code is in the javascirpt file
[12:26:00 EST(-0500)] <EricDalquist> ah ok
[12:26:03 EST(-0500)] <athena> and the problem is that one of the classnames changed
[12:26:07 EST(-0500)] <EricDalquist> ah
[12:26:10 EST(-0500)] <EricDalquist> that was my guess
[12:26:16 EST(-0500)] <athena> up-portlet-container to up-portlet-wrapper
[12:26:17 EST(-0500)] <athena> yeah
[12:26:17 EST(-0500)] <EricDalquist> but I couldn't remember where the js was
[12:26:21 EST(-0500)] <athena> should be easy enough to fix
[12:26:26 EST(-0500)] <athena> ajax-preferences-jquery.js
[12:26:36 EST(-0500)] <EricDalquist> maybe in 3.3 we can work on standardizing our JS a bit more
[12:26:43 EST(-0500)] <EricDalquist> maybe move it all to just .js files
[12:26:50 EST(-0500)] <EricDalquist> and not have anything in the XSL if at all possible
[12:27:20 EST(-0500)] <athena> i don't think we do have much in the XSL
[12:27:25 EST(-0500)] <athena> but yes, standardization would be good