Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

[09:28:30 EST(-0500)] * jessm (n=Jess@c-71-232-1-65.hsd1.ma.comcast.net) has joined ##uportal
[09:44:22 EST(-0500)] * lennard1 (n=sparhk@68.98.56.21) has joined ##uportal
[09:44:57 EST(-0500)] * athena (n=athena@adsl-99-136-250-158.dsl.wlfrct.sbcglobal.net) has joined ##uportal
[10:09:06 EST(-0500)] * colinclark (n=colin@bas2-toronto09-1176131079.dsl.bell.ca) has joined ##uportal
[10:13:47 EST(-0500)] * holdorph (n=holdorph@wsip-72-215-204-133.ph.ph.cox.net) has joined ##uportal
[10:39:04 EST(-0500)] * tsnfoo (n=tsnfoo@cpe-173-88-27-191.columbus.res.rr.com) has joined ##uportal
[11:13:10 EST(-0500)] * athena (n=athena@adsl-99-136-250-158.dsl.wlfrct.sbcglobal.net) has joined ##uportal
[11:13:37 EST(-0500)] * michelled (n=michelle@142.150.154.193) has joined ##uportal
[11:48:02 EST(-0500)] * EricDalquist (n=dalquist@bohemia.doit.wisc.edu) has joined ##uportal
[12:12:11 EST(-0500)] * awills (n=awills@72.215.204.133) has joined ##uportal
[12:12:43 EST(-0500)] <awills> FYI... SafeFileNamePhraseTest.java is giving me grief
[12:13:31 EST(-0500)] <awills> "contains charaters that do not exist in code page 1252 (ANSI - Latin I)"
[12:14:27 EST(-0500)] <awills> and also from maven: http://uportal.pastebin.com/d493b259c
[12:14:43 EST(-0500)] <EricDalquist> hrm
[12:14:47 EST(-0500)] <EricDalquist> I wonder if it is a svn issue
[12:14:52 EST(-0500)] <EricDalquist> it should contain UTF-8 chars
[12:14:57 EST(-0500)] <awills> ah, that could be
[12:15:02 EST(-0500)] <EricDalquist> and should be checked out as a UTF-8 file
[12:15:19 EST(-0500)] <EricDalquist> since the test is testing for handling of non latin files
[12:15:49 EST(-0500)] <awills> yeah, it reads as though it's specifically trying to do what the tools are complaining about
[12:16:23 EST(-0500)] <EricDalquist> yup, it was fixing a bug reported by a Chinese user
[12:17:21 EST(-0500)] <awills> nice to have that kind of feedback
[12:18:23 EST(-0500)] <EricDalquist> athena: wasn't there a svn config that you were talking about a while ago?
[12:18:58 EST(-0500)] <athena> yeah
[12:19:13 EST(-0500)] <EricDalquist> http://www.ja-sig.org/wiki/display/UPC/uPortal+3+Subversion+Configuration ?
[12:19:17 EST(-0500)] <athena> though i believe it needs to be configured locally
[12:19:17 EST(-0500)] <athena> yes
[12:19:22 EST(-0500)] <athena> that's the file i use
[12:19:33 EST(-0500)] <EricDalquist> ok
[12:19:34 EST(-0500)] <EricDalquist> hrm
[12:19:38 EST(-0500)] <EricDalquist> that doesn't seem to address encoding
[12:19:40 EST(-0500)] <EricDalquist> just eol style
[12:19:44 EST(-0500)] <athena> yeah
[12:19:51 EST(-0500)] <athena> there might be an encoding option, i'm not sure
[12:21:56 EST(-0500)] <EricDalquist> awills: this is from running ant/mvn from the command line?
[12:22:06 EST(-0500)] <awills> yep
[12:22:16 EST(-0500)] <awills> ant clean deploy-war was the command
[12:23:13 EST(-0500)] <EricDalquist> can you edit the root uportal pom.xml
[12:23:58 EST(-0500)] <EricDalquist> at the bottom of the <properties> section
[12:23:59 EST(-0500)] <EricDalquist> add
[12:24:00 EST(-0500)] <EricDalquist> <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
[12:24:36 EST(-0500)] <awills> i think so
[12:25:46 EST(-0500)] <awills> done, running mvn test
[12:28:50 EST(-0500)] <awills> same build failure
[12:28:53 EST(-0500)] <awills> no change
[12:28:57 EST(-0500)] <EricDalquist> ok
[12:28:58 EST(-0500)] <EricDalquist> next
[12:29:21 EST(-0500)] <EricDalquist> find
[12:29:22 EST(-0500)] <EricDalquist> <artifactId>maven-compiler-plugin</artifactId>
[12:29:27 EST(-0500)] <EricDalquist> in the build/plugins
[12:29:41 EST(-0500)] <EricDalquist> in the configuration block add
[12:29:42 EST(-0500)]

Wiki Markup
&lt;EricDalquist&gt; &lt;encoding&gt;${project.build.sourceEncoding}&lt;/encoding&gt;

[12:30:57 EST(-0500)] <awills> k, working on it
[12:34:06 EST(-0500)] <holdorph> wouldn't using the \u style of representing UTF-8 characters work?
[12:36:45 EST(-0500)] <EricDalquist> well uPortal should (and should have since early 2.x) be considered UTF-8
[12:37:07 EST(-0500)] <EricDalquist> there has been UTF-8 characters in included files since at least 2.4
[12:37:07 EST(-0500)] <holdorph> i just meant for the characters inside the double quotes in the .java file
[12:37:40 EST(-0500)] <holdorph> instead of the whacked out characters betweenn the double quotes, using \u0069 style
[12:37:45 EST(-0500)] <EricDalquist> right, but if you can use UTF8 that works too
[12:38:05 EST(-0500)] <EricDalquist> then I need to go figure out the \u codes for the characters provided in the bug report (tongue)
[12:38:12 EST(-0500)] <holdorph> but it's not working for multiple people right now (drew wills and curtis garmin)
[12:38:19 EST(-0500)] <EricDalquist> right
[12:38:21 EST(-0500)] <holdorph> there are utilities for that
[12:38:29 EST(-0500)] <EricDalquist> and I think it is a pom.xml config issue
[12:38:32 EST(-0500)] <holdorph> i think one ships with the jdk
[12:39:03 EST(-0500)] <holdorph> you might get the mvn build to work, but it will probably just end up being a problem in other places too
[12:39:08 EST(-0500)] <holdorph> like eclipse
[12:39:17 EST(-0500)] <EricDalquist> right
[12:39:22 EST(-0500)] <EricDalquist> but if we don't fix it the right way
[12:39:30 EST(-0500)] <EricDalquist> all the XSL and properties files will get corrupted too
[12:39:39 EST(-0500)] <EricDalquist> when people build on machines that don't use UTF-8 by default
[12:40:14 EST(-0500)] <holdorph> i don't understand how updating the compiler plugin is going to affect XSL files
[12:40:23 EST(-0500)] <EricDalquist> well there are two updates
[12:40:29 EST(-0500)] <EricDalquist> once is the first thing I asked him to do
[12:40:37 EST(-0500)] <EricDalquist> which sets the default encoding for dealing with resources
[12:40:40 EST(-0500)] <EricDalquist> which wasn't set
[12:40:46 EST(-0500)] <EricDalquist> the second is setting the encoding for the compiler plugin