Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

[11:03:42 CDT(-0500)] <EricDalquist> while digging through the guest user instance code in trunk last night I had a thought for future work
[11:04:03 CDT(-0500)] <EricDalquist> it would be good to replace that boolean isGuest() method with a enum of getAuthenticationLevel
[11:04:22 CDT(-0500)] <EricDalquist> so we can directly describe things like anonymous, remember-me, single-facter, etc...
[11:08:46 CDT(-0500)] <athena> yes!
[11:09:09 CDT(-0500)] <athena> i quite agree - that was an annoyance when we talked about remember me a few years ago at yale
[11:09:11 CDT(-0500)] <EricDalquist> it would also make the checks we need to do in various places more obvious
[11:09:18 CDT(-0500)] <athena> though we'd need to think about what we do with portlets
[11:09:21 CDT(-0500)] <athena> yes
[11:09:34 CDT(-0500)] <EricDalquist> since by removing the GuestUser* stuff there are places that need a little more logic
[11:09:58 CDT(-0500)] <EricDalquist> to check and see if the user is authed at a high enough level that what they are doing should be persisted
[11:10:14 CDT(-0500)] <EricDalquist> portlet preferences already have that logic built in
[11:10:37 CDT(-0500)] <athena> was thinking more the portlet spec's isAuthenticated method?
[11:10:41 CDT(-0500)] <EricDalquist> where it stores the changes in memory instead of the DB if they are a guest
[11:10:43 CDT(-0500)] <athena> or whatever that relevant method is called