Page Comparison

[12:19:52 CDT(-0500)] <athena> EricDalquist: we shouldn't have portlet parameters that start with PORTLET. anymore, right?
[12:20:00 CDT(-0500)] <EricDalquist> right
[12:20:17 CDT(-0500)] <EricDalquist> there is are separate preference elements for portlet preferences now
[12:21:10 CDT(-0500)] <athena> yeah
[12:21:18 CDT(-0500)] <athena> that's a hold over from when there wasn't, right?
[12:21:32 CDT(-0500)] <EricDalquist> yup
[12:21:35 CDT(-0500)] <athena> going through and adding support for readOnly preferences back into the portlet admin portlet
[12:21:43 CDT(-0500)] <athena> and need to fix the parameters and review pages
[12:21:45 CDT(-0500)] <EricDalquist> ah got it
[12:21:51 CDT(-0500)] <athena> drives me crazy how messy this code is :/
[12:22:01 CDT(-0500)] <athena> really hard to write unit tests w/ all the groups and permission stuff
[12:23:52 CDT(-0500)] <EricDalquist> yeah it is
[12:27:56 CDT(-0500)] <athena> will be nice to eventually get that fixed
[12:51:41 CDT(-0500)] <athena> do we still have a use case for arbitrary portlet parameters? i'm kind of thinking no
[12:53:09 CDT(-0500)] <EricDalquist> like just letting the user enter random stuff for the portlet layout parameters?
[12:57:14 CDT(-0500)] <athena> yeah
[12:57:34 CDT(-0500)] <athena> i think we used to have that because individual IChannels might need some custom parameter
[12:57:45 CDT(-0500)] <athena> and if you were using the "custom" channel type it wouldn't knwo to prompt
[12:57:55 CDT(-0500)] <athena> but i don't know that we need it anymoreO?
[12:58:20 CDT(-0500)] <EricDalquist> right
[12:58:30 CDT(-0500)] <EricDalquist> and I don't think we would
[12:58:41 CDT(-0500)] <EricDalquist> since they are now only used by the XSL
[12:58:41 CDT(-0500)] <athena> ok
[12:58:43 CDT(-0500)] <athena> yeah
[12:58:53 CDT(-0500)] <athena> and you can pretty easily add a new param into the CPD
[12:59:10 CDT(-0500)] <athena> want me to pull that stuff out?
[12:59:28 CDT(-0500)] <EricDalquist> sure
[12:59:45 CDT(-0500)] <EricDalquist> and we have like a 'shared cpd' that most of the other CPDs build off of right?
[12:59:50 CDT(-0500)] <EricDalquist> so you can even just add it in one spot?