Add caching to two DB PAGS methods

Description

Both of these methods in JpaPersonAttributesGroupDefinitionDao…

do not appear to use caching, at all.

The “normal” way query caching is implemented in uPortal+JPA is through the createCachedQuery() method — which these 2 methods don’t call.

Needless to say, these methods are called very frequently.

I threw some System.outs into them and redeployed; here is the output from simply logging in as admin (no guest view, no clicks after AuthN)…

INFO: Server startup in 49954 ms

  1.  

    1. getPersonAttributesGroupDefinitionByName=Mobile Device Access

    2. getPersonAttributesGroupDefinitionByName=Respondr Theme Users

    3. getPersonAttributesGroupDefinitionByName=Respondr Theme Users

    4. getPersonAttributesGroupDefinitionByName=Respondr Theme Users

    5. getParentPersonAttributesGroupDefinitions=Respondr Theme Users

    6. getPersonAttributesGroupDefinitionByName=PAGS Root

    7. getParentPersonAttributesGroupDefinitions=PAGS Root

    8. getPersonAttributesGroupDefinitionByName=PAGS Root

    9. getParentPersonAttributesGroupDefinitions=PAGS Root

    10. getPersonAttributesGroupDefinitionByName=PAGS Root

    11. getPersonAttributesGroupDefinitionByName=All Users (PAGS)

    12. getPersonAttributesGroupDefinitionByName=All Users (PAGS)

    13. getPersonAttributesGroupDefinitionByName=All Users (PAGS)

    14. getParentPersonAttributesGroupDefinitions=All Users (PAGS)

    15. getPersonAttributesGroupDefinitionByName=PAGS Root

    16. getParentPersonAttributesGroupDefinitions=PAGS Root

    17. getPersonAttributesGroupDefinitionByName=PAGS Root

    18. getParentPersonAttributesGroupDefinitions=PAGS Root

    19. getPersonAttributesGroupDefinitionByName=PAGS Root

    20. getPersonAttributesGroupDefinitionByName=Desktop Device Access

    21. getPersonAttributesGroupDefinitionByName=Desktop Device Access

    22. getPersonAttributesGroupDefinitionByName=Desktop Device Access

    23. getParentPersonAttributesGroupDefinitions=Desktop Device Access

    24. getPersonAttributesGroupDefinitionByName=PAGS Root

    25. getParentPersonAttributesGroupDefinitions=PAGS Root

    26. getPersonAttributesGroupDefinitionByName=PAGS Root

    27. getParentPersonAttributesGroupDefinitions=PAGS Root

    28. getPersonAttributesGroupDefinitionByName=PAGS Root

    29. getPersonAttributesGroupDefinitionByName=PAGS Root

    30. getPersonAttributesGroupDefinitionByName=Authenticated Users

    31. getPersonAttributesGroupDefinitionByName=Authenticated Users

    32. getPersonAttributesGroupDefinitionByName=Authenticated Users

    33. getParentPersonAttributesGroupDefinitions=Authenticated Users

    34. getPersonAttributesGroupDefinitionByName=PAGS Root

    35. getParentPersonAttributesGroupDefinitions=PAGS Root

    36. getPersonAttributesGroupDefinitionByName=PAGS Root

    37. getParentPersonAttributesGroupDefinitions=PAGS Root

    38. getPersonAttributesGroupDefinitionByName=PAGS Root

    39. getPersonAttributesGroupDefinitionByName=Authenticated Users

    40. getParentPersonAttributesGroupDefinitions=Authenticated Users

    41. getPersonAttributesGroupDefinitionByName=PAGS Root

    42. getParentPersonAttributesGroupDefinitions=PAGS Root

    43. getPersonAttributesGroupDefinitionByName=PAGS Root

    44. getParentPersonAttributesGroupDefinitions=PAGS Root

    45. getPersonAttributesGroupDefinitionByName=All Users (PAGS)

    46. getParentPersonAttributesGroupDefinitions=All Users (PAGS)

    47. getPersonAttributesGroupDefinitionByName=PAGS Root

    48. getParentPersonAttributesGroupDefinitions=PAGS Root

    49. getPersonAttributesGroupDefinitionByName=Respondr Theme Users

    50. getParentPersonAttributesGroupDefinitions=Respondr Theme Users

    51. getPersonAttributesGroupDefinitionByName=PAGS Root

    52. getParentPersonAttributesGroupDefinitions=PAGS Root

    53. getPersonAttributesGroupDefinitionByName=Desktop Device Access

    54. getParentPersonAttributesGroupDefinitions=Desktop Device Access

    55. getPersonAttributesGroupDefinitionByName=PAGS Root

    56. getParentPersonAttributesGroupDefinitions=PAGS Root

    57. getPersonAttributesGroupDefinitionByName=Mobile Device Access

    58. getPersonAttributesGroupDefinitionByName=Mobile Device Access

    59. getPersonAttributesGroupDefinitionByName=Mobile Device Access

Environment

None

Status

Assignee

Andrew Wills

Reporter

James Wennmacher

Labels

None

Estimated End Date

None

Audience

None

Fix versions

Affects versions

4.1.2
4.2.0
4.1.0
4.1.1

Priority

Critical
Configure