Uploaded image for project: 'CAS Server'
  1. CAS-1196

CASImpl:grantServiceTicket() Javadocs are misleading

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.5.0, 3.5.1
    • Fix Version/s: 4.0 RC1, 4.0
    • Component/s: Documentation
    • Labels:
      None

      Description

      While looking at CentralAuthenticationServiceImpl.java, I noticed something strange. There are two overloaded methods for grantServiceTicket().

      • The one that accepts ‘credentials’ says in its javadocs: ‘throws IllegalArgumentException if TicketGrantingTicket ID, Credentials or Service are null.’ 1
      • The one that does not accept ‘credentials’ passed null instead. No exceptions are thrown. 2

      I am guessing the docs are misleading.

        Attachments

          Activity

            People

            • Assignee:
              battags ScottS
              Reporter:
              mmoayyed Misagh Moayyed
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: