excessive logging when tickets expire

Description

Issue from cas-user list copy and link below:
https://lists.wisc.edu/read/messages?id=18524654

The WebFlow action is probably logging it. ?We can reduce the logging there as we don't expect you to do anything with it.

Can you log an improvement issue for that and assign it to me?

Thanks
Scott

On Tue, Aug 21, 2012 at 11:33 AM, Ken Hohl <kenneth.hohl@us.thewg.com> wrote:

Every time we try to use an expired ticket. ?Code snippet below. ?Note the block that throws an exception if the ticket is expired. ?The problem is that nothing seems to catch this exception and deal with it more gracefully than logging an error with a full stack.

@Audit(
? ? action="SERVICE_TICKET",
? ? actionResolverName="GRANT_SERVICE_TICKET_RESOLVER",
? ? resourceResolverName="GRANT_SERVICE_TICKET_RESOURCE_RESOLVER")
@Profiled(tag="GRANT_SERVICE_TICKET", logFailuresSeparately = false)
@Transactional(readOnly = false)
public String grantServiceTicket(final String ticketGrantingTicketId, final Service service, final Credentials credentials) throws TicketException {

? ? Assert.notNull(ticketGrantingTicketId, "ticketGrantingticketId cannot be null");
? ? Assert.notNull(service, "service cannot be null");

? ? final TicketGrantingTicket ticketGrantingTicket;
? ? ticketGrantingTicket = (TicketGrantingTicket) this.ticketRegistry.getTicket(ticketGrantingTicketId, TicketGrantingTicket.class);

? ? if (ticketGrantingTicket == null) {
? ? ? ? throw new InvalidTicketException();
? ? }

? ? synchronized (ticketGrantingTicket) {
? ? ? ? if (ticketGrantingTicket.isExpired()) {
? ? ? ? ? ? this.ticketRegistry.deleteTicket(ticketGrantingTicketId);
? ? ? ? ? ? throw new InvalidTicketException();
? ? ? ? }
? ? }

You are currently subscribed to cas-user@lists.jasig.org as: scott.battaglia@gmail.com
To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-user

Hi,?

Is this error every time a ticket expires or every time you try to use an expired ticket?

Thanks
Scott

On Thu, Aug 16, 2012 at 11:08 AM, Ken Hohl <kenneth.hohl@us.thewg.com> wrote:

We're using CAS 3.4.2.1 on JBoss5 clustered with JBossCache3. ?Every time a ticket expires we get the following error in our log (I have filtered out all the apache, spring, etc entries) and left just CAS and our customization entries (none of which exist for this error).

Our confusion is that this does not seem like an error but normal operation. ?In addition, the stack dump is quite long and this occurs pretty frequently.

Since we are not experiencing any functionality issues, we are not terribly concerned, but would like to both ensure there is not something wrong that is not obvious and reduce the size of our logs.

2012-08-15 11:42:49,489 ERROR [org.jasig.cas.integration.restlet.TicketGrantingTicketResource] (ajp-10.208.55.108-8009-4)
org.jasig.cas.ticket.InvalidTicketException
? ? ? ? at org.jasig.cas.CentralAuthenticationServiceImpl.grantServiceTicket_aroundBody2(CentralAuthenticationServiceImpl.java:181)
? ? ? ? at org.jasig.cas.CentralAuthenticationServiceImpl.grantServiceTicket_aroundBody3$advice(CentralAuthenticationServiceImpl.java:44)
? ? ? ? at org.jasig.cas.CentralAuthenticationServiceImpl.grantServiceTicket(CentralAuthenticationServiceImpl.java:1)
? ? ? ? at org.jasig.cas.CentralAuthenticationServiceImpl.grantServiceTicket_aroundBody4(CentralAuthenticationServiceImpl.java:244)
? ? ? ? at org.jasig.cas.CentralAuthenticationServiceImpl.grantServiceTicket_aroundBody5$advice(CentralAuthenticationServiceImpl.java:44)
? ? ? ? at org.jasig.cas.CentralAuthenticationServiceImpl.grantServiceTicket(CentralAuthenticationServiceImpl.java:1)
? ? ? ? at org.jasig.cas.integration.restlet.TicketGrantingTicketResource.acceptRepresentation(TicketGrantingTicketResource.java:78)


You are currently subscribed to cas-user@lists.jasig.org as: scott.battaglia@gmail.com
To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-user

Environment

Windows 2k3 Server

Status

Assignee

ScottS

Reporter

Ken Hohl

Labels

None

Estimated End Date

None

Audience

None

Fix versions

Affects versions

3.4.2

Priority

Minor